-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Eigen-CppAD skeleton #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
force-pushed
the
feature/add_AD_skeleton
branch
from
July 21, 2020 14:36
d20d186
to
27d0d76
Compare
S-Dafarra
reviewed
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only real comment is about the dependency in the CMakelists. The other is marginal
This feature is not supported yet by Windows. As soon as microsoft/vcpkg#12560 is merged I think we can start supporting also Windows |
@S-Dafarra let me know if I can merge the PR |
S-Dafarra
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some utilities to use
CppAD
withEigen
In details:Findcppad.cmake
has been designed to findcppad
thoughtpkg_config
orcppad_DIR
Right now it works only on Linux and MacOS.AutoDiff/CppAD.h
includes and implements some utilities functions to useCppAD
withEigen
(e.g. see hereKnown issue: There seems that it is not possible to use
CppAD
inside Eigenvector fixed size see here