Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #3

Closed
S-Dafarra opened this issue Sep 2, 2020 · 6 comments · Fixed by #9
Closed

Add CI #3

S-Dafarra opened this issue Sep 2, 2020 · 6 comments · Fixed by #9
Assignees

Comments

@S-Dafarra
Copy link
Member

No description provided.

@S-Dafarra S-Dafarra self-assigned this Sep 2, 2020
@S-Dafarra
Copy link
Member Author

This will be done right before setting this repo to public, which will be done after finishing a basic set of features

@S-Dafarra
Copy link
Member Author

In https://github.com/dic-iit/matio-cpp/tree/actions I am adding the Actions. Currently:

/Users/runner/work/matio-cpp/matio-cpp/include/matioCpp/ForwardDeclarations.h:114:1: error: unknown type name 'constexpr'

@traversaro @GiulioRomualdi any hint?

@S-Dafarra
Copy link
Member Author

Regarding

  • MacOs fails because of an error like

/Users/runner/work/matio-cpp/matio-cpp/include/matioCpp/ForwardDeclarations.h:114:1: error: unknown type name 'constexpr'

I guess it is because I am not adding the constexpr feature in CMake

@S-Dafarra
Copy link
Member Author

Regarding

  • MacOs fails because of an error like

/Users/runner/work/matio-cpp/matio-cpp/include/matioCpp/ForwardDeclarations.h:114:1: error: unknown type name 'constexpr'

I guess it is because I am not adding the constexpr feature in CMake

171720e fixes the issue

Regarding

it has been fixed on master few hours ago. I guess I have to download vcpkg manually to specify a given version, right?

@traversaro
Copy link
Collaborator

Regarding

it has been fixed on master few hours ago. I guess I have to download vcpkg manually to specify a given version, right?

I am afraid it is necessary. One possibility is to use the run-vcpkg action, see https://github.com/ros-industrial/abb_libegm/blob/master/.github/workflows/windows-vcpkg.yml#L20 .

@S-Dafarra
Copy link
Member Author

I am afraid it is necessary. One possibility is to use the run-vcpkg action, see https://github.com/ros-industrial/abb_libegm/blob/master/.github/workflows/windows-vcpkg.yml#L20 .

That worked, thanks. Facing now some compilation issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants