-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH Actions #9
Conversation
…test fail to compile on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
.github/workflows/ci.yml
Outdated
schedule: | ||
# * is a special character in YAML so you have to quote this string | ||
# Execute a "nightly" build at 2 AM UTC | ||
- cron: '0 2 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember there is a time limit for the GitHub action when the repo is private. Probably we should avoid to periodically run the action every 2AM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I have removed it in c5e43bd
CMakeLists.txt
Outdated
@@ -58,6 +58,8 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON) | |||
# extensions off. | |||
set(CMAKE_C_EXTENSIONS OFF) | |||
set(CMAKE_CXX_EXTENSIONS OFF) | |||
set(CMAKE_CXX_STANDARD 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is required? Please check this issue: robotology/how-to-export-cpp-library#44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On MacOs
it was not compiling because it was not getting the correct standard. I bumped the CMake minimum version to 3.10 to have the cxx_std_14
compile feature.
Avoid the Actions to be run every day.
@GiulioRomualdi let me know if the modifications are ok for you |
Fine thanks. Regarding this instead?
@traversaro any idea? |
I have disabled it for the moment. I will turn the scheduling on again when I will open it. Here the details on the available minutes: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions |
Closes #3