Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds reflection and conversions from common types #55

Merged
merged 22 commits into from
Apr 28, 2022
Merged

Adds reflection and conversions from common types #55

merged 22 commits into from
Apr 28, 2022

Conversation

S-Dafarra
Copy link
Member

@S-Dafarra S-Dafarra commented Mar 25, 2022 •
edited

I also fixed the CI failures and some issues with the license

Fix #53

@S-Dafarra
Added test case to check if a span can be constructed automatically w…
8990b70 
…hen passing a vector as input parameter.
@S-Dafarra
Added ExogenousConversions, including Eigen
69c1194
@S-Dafarra
Added more sophisticated conversions from iterators.
da83f9c
@S-Dafarra
Attempt to fix macOS failure.
f19882e
@S-Dafarra
Yet another attempt to fix macOS failure.
685c33c
@S-Dafarra
Updated ci to test windows only with conda and added eigen only in co…
c4f7aa9 
…nda.
@S-Dafarra
Inverted the parameters when calling make_variable.
3030863 
The Variable constructor is such that the first parameter is always the name.
@S-Dafarra
Bumped version
4c81bec
@S-Dafarra
Moved non-template conversions to dedicated cpp file.
2969d17
@S-Dafarra
First version using visit_struct to automatically convert structs to …
8a024f9 
…matio structs
@S-Dafarra
Attempt to fix windows issues in the tests related to the comparison …
bf7b2d1 
…of iterators.
@S-Dafarra
Using FetchContent to retrieve visit_struct
459f1f5
@S-Dafarra
Improved README to consider exogenous conversions.
1485168
@S-Dafarra
Updated CHANGELOG
75fffef
@S-Dafarra S-Dafarra self-assigned this Mar 25, 2022
@S-Dafarra S-Dafarra mentioned this pull request Mar 25, 2022
Closed
@S-Dafarra S-Dafarra linked an issue Mar 25, 2022 that may be closed by this pull request
Investigate the possibility of automatically converting a struct into a matioCpp struct using reflection #53
Closed
@S-Dafarra S-Dafarra mentioned this pull request Mar 30, 2022
Open
@S-Dafarra
Copy link
Member Author

@traversaro @GiulioRomualdi friendly ping

traversaro
traversaro approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@S-Dafarra
Copy link
Member Author

Thanks a lot @traversaro. Merging

@S-Dafarra S-Dafarra merged commit ed9b196 into master Apr 28, 2022
@S-Dafarra S-Dafarra deleted the conversions branch April 28, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@GiulioRomualdi GiulioRomualdi Awaiting requested review from GiulioRomualdi

Assignees

@S-Dafarra S-Dafarra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate the possibility of automatically converting a struct into a matioCpp struct using reflection
2 participants
@S-Dafarra @traversaro