Remove jQuery #425
Merged
Remove jQuery #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
reviewed
May 13, 2020
| @@ -2864,4 +2863,5 @@ <h3>*****Longer title*****</h3> | |||
| </footer> | |||
| </div><!-- ends "grid" --> | |||
| </body> | |||
| <script src="js/js.js"></script> | |||
There was a problem hiding this comment.
Are you sure this should not remain inside the <head> rather than at the <html> level?
There was a problem hiding this comment.
Oh thanks, let me move it up! Or it will be invalid html.
privatezero
approved these changes
May 13, 2020
kfrn
approved these changes
May 13, 2020
js/js.js
Outdated
| } | ||
|
|
||
| // add hash URL when recipe is opened | ||
| let recipes = document.querySelectorAll('label[class="recipe"]') |
There was a problem hiding this comment.
(minor) recipes (and some of the other let variables) can be consts, no?
There was a problem hiding this comment.
yes! thanks @kfrn -- clearly was just being lazy here
retokromer
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the jQuery library for a few things, but I replaced these things with plain ol' Javascript.
I did some testing here, but it could definitely use more thorough testing to make sure I cleaned it up right! Pushing this now just so I can move on to other tasks today. ;) But will rush back to fix anything that didn't successfully make the transition.