Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle complex variable names with backticks #631

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

Ralayax
Copy link
Contributor

@Ralayax Ralayax commented Mar 26, 2024

Uses backticks to handle complex variable names

Fixes #630

(I'm pretty new to R packages and I don't know a lot about the mice repo so forgive me if this isn't up to standards)

@stefvanbuuren
Copy link
Member

When I do usethis::pr_fetch(631) I get

Error in libgit2::git_remote_fetch : unexpected http status code: 404

Not quite sure why that is. Perhaps fetching from a feature branch instead of master might work?

@stefvanbuuren
Copy link
Member

Now it works, after solving a typo in the remotes.

Thanks a lot. I ran some examples, and there it worked very well. Although we should not encourage slopping names, it is useful to support them, so I'll merge.

@stefvanbuuren stefvanbuuren merged commit 3063d35 into amices:master Apr 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mice doesn't handle complex variable names
2 participants