Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for trivial minpuc argument in quickpred #634

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

stephematician
Copy link
Contributor

Use any(minpuc != 0) which supports scalar, vector, and matrix in the short-circuit test for trivial minpuc.

Added tests that check that the basic types for each argument (as documented) are supported. Also added a test to check that the return value is as per documentation (square, binary matrix).

use any() in test for trivial minpuc
Tests for acceptable arguments
Tests for output format
@stephematician
Copy link
Contributor Author

  1. No idea why ubuntu-latest is failing at the dependency action.
  2. On my machine, another test fails:
── Failed tests ───────────────────────────────────────────────────────────────
Failure (test-parlmice.R:15:3): Imputations are equal between mice and parlmice
complete(C, "long") not identical to complete(D, "long").
Component “bmi”: Mean relative difference: 0.1664327
Component “hyp”: Mean relative difference: 0.6666667
Component “chl”: Mean relative difference: 0.1966936

[ FAIL 1 | WARN 0 | SKIP 0 | PASS 383 ]

@stephematician
Copy link
Contributor Author

Removing Matrix extra dependency in R-CMD-check does (seem to) fix the workflow.

@stefvanbuuren stefvanbuuren merged commit 1ccf74f into amices:master Apr 17, 2024
10 of 12 checks passed
@stefvanbuuren
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants