Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: algorithm stops when method is specified, but predictor relations are empty #99

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

gerkovink
Copy link
Member

This solves #96.

A column is now excluded from imputation if an imputation method is provided while the predictor relations are user-specified as empty. This conforms to the following behaviour:

Method specified Predictors specified Parsed to sampler? Scenario
Yes Yes Yes Default or correct user-specification
No Yes No method indicates no imputation
Yes No No unable to impute because of custom [misspecified?] predictorMatrix
No No No Default or correct user-specification

@stefvanbuuren stefvanbuuren merged commit 3400c51 into amices:master Jun 8, 2018
@stefvanbuuren
Copy link
Member

stefvanbuuren commented Jun 8, 2018

I tweaked this a little since predictorMatrix[h, ] only exists when calltype == "type" (46c69ba)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants