-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution of multiple event assignments from the same event #2430
Comments
Yes, sounds correct. |
Might have been correct before. I don't quite understand why, yet. But changing that leads to failures in: |
From elsewhere in the SBML spec (sec 4.6.8):
It's not exactly intuitive and quite possibly a common source of error, but the present implementation is correct. |
Multiple event assignments from the same event should be executed simultaneously. From the SBML L3V2 specs:
However, that doesn't seem to be the case:
AMICI/python/sdist/amici/sbml_import.py
Lines 1670 to 1673 in da19a55
I'd say, in the
else
case, that assignment should be ignored.Example: Assuming a model with a concentration-based species S in compartment C, and an event with two event assignments – EA_S assigning to S and EA_C assigning to C.
In this case, S should only change due to EA_S, but not due to the volume change caused by EA_C. Currently, first EA_S is applied, then EA_C.
Correct?
The text was updated successfully, but these errors were encountered: