-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with "Reboot Later" #1174
Comments
Please note, this behavior existed on two different tacticalrmm installations, the first was Ubuntu 20.04 LTS based, and the second Debian 11. I rebuilt my server onto the Debian OS over the weekend in an effort to clear up some lingering redis issues. Redis is now quite happier! But the UI bug remains. :) |
I have fixed the 400 timeout error when date is in past in e8e19fe (this was actually causing the agent to crash LOL which is why the timeout). As for the invalid date issue, I am having a hard time reproducing it, I have tried typing the values by hand instead of using the GUI but don't get any errors. Only time I get error is if I type an invalid year. Any way to record a GIF or video of how to consistently reproduce? Thanks. |
Those are screenshots from firefox...different date picker than chrome, but I can't get it to do it either now. Maybe it's fixed? |
Yes I tried both firefox and chrome, probably was fixed in a quasar update |
I can also confirm that the issue has gone away in chrome. |
Post if found to be a problem still |
Fixed (again lol) in Release 0.14.6 |
Same issue here in v0.15.7, did not test in v0.15.9... |
Maybe reboot has the same TZ logic problem as 9f95c57 ? |
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information):
Describe the bug
Firefox displays a different UI tool to select the date time stamp passed for the scheduled reboot. Firefox only shows the calendar portion, no time selector is available.
If a reboot is scheduled for a time that has already passed, a 400 timeout error is returned. This may be intentional, but seems like it should be handled a little more gracefully.
During the scheduling process, if any of the elements are typed in manually the scheduling event returns a 400 invalid date error.
If on Firefox, once this corruption is revealed the only way to clear it is to refresh the browser and try again without actually typing anything in. Which limits the user to changing the date alone.
If on a Chromium browser the mangled date time can be fixed by clicking the day on the calendar intended. If a manual date is typed in, both today and that date will be selected on the calendar, and clicking the correct day will result in a working time stamp that successfully schedules.
On both browsers if the seconds value on the time is reduced to 00, it will simply vanish once a date is chosen on the calendar. Firefox doesn't display the time selector tools at all and will return an invalid date error when such a shortened timestamp is used. Chromium based browsers lose the seconds column in the time selector portion of the UI but seem to schedule properly assuming a date is selected on the calendar as a final action first.
To Reproduce
Steps to reproduce the behavior:
(See above for using the UI to "fix" things)
Expected behavior
I expect to be able to type in a proper date / time string, or select one from the UI and have it work the first time. It would also be nice if I could copy / paste the entire date time string into the reboot time box so I can rapidly schedule multiple reboots quickly.
Screenshots
![image](https://user-images.githubusercontent.com/45128329/173930177-0863e3d1-6871-4d5e-82b9-07badc7d4194.png)
![image](https://user-images.githubusercontent.com/45128329/173930230-51d7f964-cbd2-4c9c-82a0-c4ed80a999b8.png)
![image](https://user-images.githubusercontent.com/45128329/173930417-3637856a-bbc1-47f5-a200-ad87e05f2c87.png)
![image](https://user-images.githubusercontent.com/45128329/173930464-f6583433-4629-4293-a7a0-e9bc8d90b4cc.png)
Additional context
Silversword was assisting me (AzulSkyknight) in #Support on Discord, searching for myself for comments from today 6-15-2022 around 9am Arizona time will find the conversation.
The text was updated successfully, but these errors were encountered: