Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating meshcentral's config casing to match upstreams json schema. #1213

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Jul 18, 2022

I have also applied formatting with prettier.
I have it on a separate commit, I can easily drop it if you like so.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #1213 (af61237) into develop (5e37728) will not change coverage.
The diff coverage is n/a.

❗ Current head af61237 differs from pull request most recent head 87d0522. Consider uploading reports for the commit 87d0522 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1213   +/-   ##
========================================
  Coverage    82.24%   82.24%           
========================================
  Files          113      113           
  Lines         7462     7462           
========================================
  Hits          6137     6137           
  Misses        1325     1325           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ninjamonkey198206
Copy link

ninjamonkey198206 commented Jul 21, 2022

Just FYI , I merged the changes to the json casing into my PR. I'd keep this open for now, though.

I'll look through the prettying up part and see if it's stuff I already did as well.

@stavros-k
Copy link
Contributor Author

Just FYI , I merged the changes to the json casing into my PR. I'd keep this open for now, though.

I'll look through the prettying up part and see if it's stuff I already did as well.

Cool! Thanks for the update!

@wh1te909
Copy link
Member

wh1te909 commented Oct 3, 2022

please preserve the existing formatting as changing formatting adds alot of noise to the PR and makes it difficult to see what exactly changed

@stavros-k
Copy link
Contributor Author

please preserve the existing formatting as changing formatting adds alot of noise to the PR and makes it difficult to see what exactly changed

Done

@wh1te909
Copy link
Member

wh1te909 commented Oct 6, 2022

great, thanks!

@wh1te909 wh1te909 merged commit 93a5dd5 into amidaware:develop Oct 6, 2022
@stavros-k stavros-k deleted the json branch October 6, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants