When checking if patches are to be installed, don't exit the function after finding a patched machine. #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her agents won't receive updates Signed-off-by: Adam <adam@csparker.co.uk>
Codecov Report
@@ Coverage Diff @@
## develop #1277 +/- ##
========================================
Coverage 82.25% 82.25%
========================================
Files 114 114
Lines 7493 7493
========================================
Hits 6163 6163
Misses 1330 1330
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
great catch thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
check_agent_update_schedule_task()will return after finding a machine which has already been patched the same day, this prevents any agents later in the list getting updates.Returning is ok if only 1 patch policy triggers per day, but if client1 patches at 03:00 and client2 patches at 19:00 then client2 won't get all patches if any agents from client1 are online.
Fixes #1270