Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added agent's custom fields to table result #1468

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

jpros
Copy link
Contributor

@jpros jpros commented Mar 30, 2023

This action is to enable search and summary in the dashboard view.

References to web:
amidaware/tacticalrmm-web#7

This action is to enable search and summary in the dashboard view.
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #1468 (4c78922) into develop (b5eed69) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c78922 differs from pull request most recent head 56124d2. Consider uploading reports for the commit 56124d2 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1468   +/-   ##
========================================
  Coverage    81.13%   81.13%           
========================================
  Files          116      116           
  Lines         7791     7792    +1     
========================================
+ Hits          6321     6322    +1     
  Misses        1470     1470           
Impacted Files Coverage Δ
api/tacticalrmm/agents/serializers.py 96.07% <100.00%> (+0.03%) ⬆️
api/tacticalrmm/tacticalrmm/settings.py 92.85% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wh1te909
Copy link
Member

wh1te909 commented Apr 3, 2023

thank you. I just need to test it on larger installs as this will add an extra db hit and so we might need to add a prefetch to the view as well to not cause n+1 query problem

@wh1te909
Copy link
Member

wh1te909 commented Apr 4, 2023

I added the prefetch to the view (ignore the failing tests, that's not related lol)

@wh1te909 wh1te909 merged commit c934065 into amidaware:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants