Skip to content

Commit

Permalink
checkstyle fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
amihaiemil committed Nov 24, 2017
1 parent 59332da commit 6cad54e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/main/java/co/comdor/SocialSteps.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
public interface SocialSteps extends Step {

/**
* Notice that this overriden perform does not throw IOException.
* Notice that this overriden perform() does not throw IOException.
* This is because we are not treating social steps failures, they are only
* cosmetic, not affecting the business at all.
* @param mention Mention which triggered everything.
* @param command Command which triggered everything.
* @param log Log of the Action.
*/
@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/co/comdor/Step.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public interface Step {

/**
* Perform this step.
* @param mention Command that triggered the action.
* @param command Command that triggered the action.
* @param log The Action's logger.
* @throws IOException If there is anything wrong in the communication
* with Github.
Expand Down
7 changes: 5 additions & 2 deletions src/main/java/co/comdor/github/Language.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ public abstract class Language {
* @param commandsFileName Properties file with commands.
* @param responsesFileName Properties file with responses.
*/
public Language(final String commandsFileName, final String responsesFileName) {
public Language(
final String commandsFileName, final String responsesFileName
) {
try {
this.commands.load(
this.getClass().getClassLoader()
Expand All @@ -81,7 +83,7 @@ public Language(final String commandsFileName, final String responsesFileName) {
* @param mention Mention where the bot has been called.
* @return String type.
* @throws IOException If something goes wrong with the call to Github.
* @checkstyle
* @checkstyle DesignForExtension (5 lines)
*/
public String categorize(final Command mention) throws IOException {
final Set<Object> keys = this.commands.keySet();
Expand All @@ -108,6 +110,7 @@ public String categorize(final Command mention) throws IOException {
* Find a response.
* @param key The response's key.
* @return String.
* @checkstyle DesignForExtension (5 lines)
*/
public String response(final String key) {
return this.responses.getProperty(key);
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/co/comdor/rest/ChatResource.java
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ public class ChatResource {
/**
* Logger.
*/
private static final Logger LOG = LoggerFactory.getLogger(ChatResource.class.getName()
private static final Logger LOG = LoggerFactory.getLogger(
ChatResource.class.getName()
);

/**
Expand Down

0 comments on commit 6cad54e

Please sign in to comment.