(#52) Configuration of Unix connection pooling #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Externalized ConnectionSocketFactory into 'UnixSocketFactory' * LocalDocker(HttpClient, String) now public for users * Added some javadocs
|
Job #60 is now in scope, role is |
* Deleted puzzle
amihaiemil
reviewed
Mar 20, 2018
| @@ -64,10 +68,14 @@ public LocalDocker(final File unixSocket, final String version){ | |||
|
|
|||
| /** | |||
| * Local Docker engine. | |||
| * <p> | |||
| * Users may supply their own {@link HttpClient} that must register a unix | |||
There was a problem hiding this comment.
@llorllale ```... that must register a {@link UnixSocketFactory}, would be better and then we can remove the @see ...``
As per PR review: * Fixed javadoc
|
@amihaiemil fixed javadoc, please review |
|
@rultor merge pls |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
The job #60 is now out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
UnixSocketFactoryLocalDocker(HttpClient, String)public for users to provide their own HttpClient