-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#52) Configuration of Unix connection pooling #60
Conversation
* Externalized ConnectionSocketFactory into 'UnixSocketFactory' * LocalDocker(HttpClient, String) now public for users * Added some javadocs
Job #60 is now in scope, role is |
* Deleted puzzle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale looks nice, just a comment
@@ -64,10 +68,14 @@ public LocalDocker(final File unixSocket, final String version){ | |||
|
|||
/** | |||
* Local Docker engine. | |||
* <p> | |||
* Users may supply their own {@link HttpClient} that must register a unix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale ```... that must register a {@link UnixSocketFactory}, would be better and then we can remove the
@see ...``
As per PR review: * Fixed javadoc
@amihaiemil fixed javadoc, please review |
@rultor merge pls |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
The job #60 is now out of scope |
This PR:
UnixSocketFactory
LocalDocker(HttpClient, String)
public for users to provide their own HttpClient