renamed entry point to ZoldWts as in issue #8 #12
Conversation
|
Job #12 is now in scope, role is |
|
This pull request #12 is assigned to @denis-konovalyenko/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
|
@ammaratef45 Please use the name And please link the original issue in the PR's description. Just say "`PR for #8". |
|
@ammaratef45 , as far as I understand, the expected change is @ammaratef45 , could you please check whether the commit message contains clear information on what kind of a problem has been fixed? I suppose you meant something like that "#8: the entry point renamed." and the "Wts ass" was just a typo, wasn't it? @amihaiemil , what about QA rules, are we going to comply with the requirements stated in the Policy? If so, then , @ammaratef45 , I would also mention the following point for considration: "Pull request description explains the solution proposed and contains a link to the original ticket it is related to". |
|
@denis-konovalyenko We don't have a QAs on the projects but yes, we should still try to respect the process as much as possible. However, we should not block PRs for small stuff like commit messages and so on. |
|
@amihaiemil , thanks for the clarification! I have added a proposal to link this to the readme section (#13). |
ammaratef45
changed the title
|
@denis-konovalyenko sorry for the typo 😆 |
.vscode/launch.test.json
Outdated
| @@ -0,0 +1,30 @@ | |||
| { | |||
There was a problem hiding this comment.
@ammaratef45 , could you please clarify what these changes are for? Do we need them in the scope of the issue #8?
There was a problem hiding this comment.
@denis-konovalyenko this file should be removed
I was using vscode and it added this file automatically and I didn't notice it
There was a problem hiding this comment.
@denis-konovalyenko I have removed it in a seperate commit
There was a problem hiding this comment.
@ammaratef45 , thanks!
|
@rultor merge |
@denis-konovalyenko Thanks for your request. @amihaiemil Please confirm this. |
|
@rultor merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
Job was finished in 43 hours, bonus for fast delivery is possible (see §36) |
|
The job #12 is now out of scope |
|
Order was finished: +20 point(s) just awarded to @denis-konovalyenko/z |
|
Job |
|
Job |
|
Payment to |
PR for #8