E2e snapshot fix (#357)

* update pipeline * fix pipeline condition * update snapshot * fix display name * comment * add cross-env * fix display name * update snapshot * ci update * Cleanup azure-pipelines.yml * Remove cross-env * add cross-env * fix snapshot for windows * remove cross-env * update yml docs * disable spec:e2e on windows * remove --ci flag
amilajack · Jun 23, 2020 · 106c83e · 106c83e
1 parent 5a23480
commit 106c83e
Show file tree

Hide file tree

Showing 2 changed files with 560 additions and 387 deletions.
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -2,6 +2,8 @@ variables:
   YARN_CACHE_FOLDER: $(Pipeline.Workspace)/.yarn
   stableNodeVersion: '12.x'
   currentNodeVersion: '14.x'
+  # Used with `eslintVersion` to see if `spec:e2e` and `benchmarks` should run
+  e2eEslintVersion: 'eslint@7.2.0'
 
 strategy:
   matrix:
@@ -104,14 +106,15 @@ steps:
     displayName: Cache Yarn packages
   - script: yarn --frozen-lockfile && yarn add --dev $(eslintVersion) && yarn test
     displayName: Install dependencies and run yarn test
-  # E2E tests use eslint@7 only feature (the Node.js API class ESLint)
+  # E2E tests use eslint@7+ only feature (the Node.js API class ESLint)
+  # Also disabled on windows because of jest snapshot problems
   - script: yarn spec:e2e
-    condition: ge(variables['eslintVersion'], 'eslint@^7')
-    displayName: Run yarn spec:e2e if >=eslint@7# Benchmarks uses eslint@7 only feature (the Node.js API class ESLint)
-  # Benchmarks use eslint@7 only feature (the Node.js API class ESLint)
+    condition: and(eq(variables['eslintVersion'], variables['e2eEslintVersion']), ne(variables['imageName'], 'vs2017-win2016'))
+    displayName: Run yarn spec:e2e if $(eslintVersion)==$(e2eEslintVersion)
+  # Benchmarks use eslint@7_ only feature (the Node.js API class ESLint)
   - script: yarn benchmarks
-    condition: ge(variables['eslintVersion'], 'eslint@^7')
-    displayName: Run benchmarks if >=eslint@7
+    condition: eq(variables['eslintVersion'], variables['e2eEslintVersion'])
+    displayName: Run yarn benchmarks if $(eslintVersion)==$(e2eEslintVersion)
   # Upload Jest code coverage
   - script: yarn spec --coverage --coverageReporters=cobertura
     displayName: Generate Jest coverage report