Skip to content

Commit

Permalink
fix #325: update peerDeps eslint version
Browse files Browse the repository at this point in the history
  • Loading branch information
@amilajack
amilajack committed May 20, 2020
1 parent ae8ccaf commit e79f72c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"semver": "7.3.2"
},
"peerDependencies": {
"eslint": "^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0"
"eslint": "^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0"
},
"engines": {
"node": ">=8.x"

This comment was marked as resolved.

Sign in to view

Copy link
@zypA13510

zypA13510 May 20, 2020 •
edited
Loading

@amilajack Node.js 8 is no longer supported, should be "node": "^10.12.0 || >=12.0.0" here.

This comment was marked as resolved.

Sign in to view

Copy link
@zypA13510

zypA13510 May 20, 2020

Also, it's a breaking change so you probably need to bump major version too, i.e. v4.0.0-0 instead of v3.7.0-1

This comment was marked as resolved.

Sign in to view

Copy link
@zypA13510

zypA13510 May 20, 2020

On second thought, if you list all eslint version since 3.0.0 as acceptable peer dependency, node >= 8.x is probably ok here. People using ESLint v6 can still use this plugin on node v8 as long as this plugin does not use features limited to v10 or above.

This comment has been minimized.

Sign in to view

Copy link
@amilajack

amilajack May 20, 2020

Author Owner

But users using node@7 will run into issues. I like your suggestion of creating a new major semver bump.

This comment has been minimized.

Sign in to view

Copy link
@zypA13510

zypA13510 May 20, 2020

@amilajack By node@7 did you mean eslint@7? No, they won't, because eslint@7 already have the said engine fields listed in their manifest.
Expand Down

0 comments on commit e79f72c

Please sign in to comment.