Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #339

Merged
merged 6 commits into from Jun 7, 2020
Merged

Refactor #339

merged 6 commits into from Jun 7, 2020

Conversation

jooohhn
Copy link
Collaborator

@jooohhn jooohhn commented Jun 6, 2020

  • Move versioning.ts and lint.ts to helpers.ts
  • Create constants.ts with STANDARD_TARGET_NAME_MAPPING
  • Rename identifiers for consistency
  • Delete kangax
  • Change versioning() -> parseBrowsersListVersion()
  • Add rough documentation

@jooohhn jooohhn requested a review from amilajack June 6, 2020 20:31
@jooohhn jooohhn added the chore Routine maintenance work label Jun 6, 2020
amilajack
amilajack requested changes Jun 6, 2020
View reviewed changes
src/config/recommended.ts Outdated Show resolved Hide resolved
src/helpers.ts Show resolved Hide resolved
@amilajack amilajack merged commit 084883a into master Jun 7, 2020
@amilajack amilajack deleted the refactor branch June 7, 2020 14:36
@edg2s edg2s mentioned this pull request Dec 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilajack amilajack amilajack approved these changes

Assignees
No one assigned
Labels
chore Routine maintenance work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jooohhn @amilajack