Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS fixes #342

Merged
merged 5 commits into from Jun 10, 2020
Merged

TS fixes #342

merged 5 commits into from Jun 10, 2020

Conversation

jooohhn
Copy link
Collaborator

@jooohhn jooohhn commented Jun 9, 2020 •
edited

  • Add expression to ESLintNode
  • Add AST_NODE_TYPES to AstMetadataApiWithUnsupportedTargets
  • Clarified CanIUseRecords (was confusing before)
  • 31 errors -> 26

@jooohhn jooohhn added the chore Routine maintenance work label Jun 9, 2020
@jooohhn jooohhn requested a review from amilajack June 9, 2020 03:25
@amilajack amilajack changed the title Ts fixes TS fixes Jun 9, 2020
amilajack
amilajack requested changes Jun 9, 2020
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
src/helpers.ts Show resolved Hide resolved
amilajack
amilajack requested changes Jun 10, 2020
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
amilajack
amilajack requested changes Jun 10, 2020
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
@jooohhn jooohhn merged commit 394c72e into master Jun 10, 2020
@jooohhn jooohhn deleted the ts-fixes branch June 10, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilajack amilajack amilajack approved these changes

Assignees
No one assigned
Labels
chore Routine maintenance work infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jooohhn @amilajack