Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fatal error check #379

Merged
merged 5 commits into from Jul 10, 2020
Merged

Move fatal error check #379

merged 5 commits into from Jul 10, 2020

Conversation

jooohhn
Copy link
Collaborator

@jooohhn jooohhn commented Jul 6, 2020

Move fatal error check from benchmarks.ts to e2e-repo.spec.ts

@jooohhn jooohhn requested a review from amilajack July 6, 2020 19:19
amilajack
amilajack reviewed Jul 6, 2020
View reviewed changes
Copy link
Owner

@amilajack amilajack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the context on the reason for this change?

@jooohhn
Copy link
Collaborator Author

jooohhn commented Jul 7, 2020

Benchmarks performed checking for fatal parsing errors caused by bad configs in repos.ts. I felt like it's better to move that to e2e-repos and let benchmarks.ts perform just benchmarking.

@amilajack
Copy link
Owner

Ah I see. Good call!

@jooohhn jooohhn merged commit b18bd6f into master Jul 10, 2020
@jooohhn jooohhn deleted the move-fatal-error-check branch July 10, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilajack amilajack amilajack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jooohhn @amilajack