Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an example value of expiration #462

Merged
merged 1 commit into from May 15, 2023

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented May 14, 2023

The expiration must be a duration, or "DeleteMarker" and can't be set int.

if (lifecycle.Expiration{}) == exp {
return diag.Errorf("expiration must be a duration (5d), date (1970-01-01), or \"DeleteMarker\"")
}

Copy link
Collaborator

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! Nice catch! Thanks for the fix!

@felladrin felladrin merged commit 244298a into aminueza:master May 15, 2023
2 checks passed
@y-yagi y-yagi deleted the fix-example-of-expiration branch May 15, 2023 21:48
doonga pushed a commit to doonga/greyrock-ops that referenced this pull request Jul 12, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [minio](https://registry.terraform.io/providers/aminueza/minio)
([source](https://togithub.com/aminueza/terraform-provider-minio)) |
required_provider | minor | `1.15.2` -> `1.16.0` |

---

### Release Notes

<details>
<summary>aminueza/terraform-provider-minio (minio)</summary>

###
[`v1.16.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.16.0)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.3...v1.16.0)

#### What's Changed

- KMS Keys and Bucket Server-Side-Encryption by
[@&#8203;tobikris](https://togithub.com/tobikris) in
[aminueza/terraform-provider-minio#486

#### New Contributors

- [@&#8203;tobikris](https://togithub.com/tobikris) made their first
contribution in
[aminueza/terraform-provider-minio#486

**Full Changelog**:
aminueza/terraform-provider-minio@v1.15.3...v1.16.0

###
[`v1.15.3`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.15.3)

[Compare
Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.2...v1.15.3)

#### What's Changed

- Fix an example value of `expiration` by
[@&#8203;y-yagi](https://togithub.com/y-yagi) in
[aminueza/terraform-provider-minio#462
- Fix group status handling by
[@&#8203;asdevcapybara](https://togithub.com/asdevcapybara) in
[aminueza/terraform-provider-minio#484

#### New Contributors

- [@&#8203;y-yagi](https://togithub.com/y-yagi) made their first
contribution in
[aminueza/terraform-provider-minio#462
- [@&#8203;asdevcapybara](https://togithub.com/asdevcapybara) made their
first contribution in
[aminueza/terraform-provider-minio#484

**Full Changelog**:
aminueza/terraform-provider-minio@v1.15.2...v1.15.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants