Fix group status handling #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
force-pushed
the
feature/fix-group-handling
branch
from
dd607b3
to
9d8e0ce
Compare
felladrin
force-pushed
the
feature/fix-group-handling
branch
from
9d8e0ce
to
82ec203
Compare
felladrin
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Congratulations on making your first contribution to this repository, @asdevcapybara! 🎉
Thanks for taking the time to fix it!
doonga
pushed a commit
to doonga/greyrock-ops
that referenced
this pull request
Jul 12, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | minor | `1.15.2` -> `1.16.0` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v1.16.0`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.16.0) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.3...v1.16.0) #### What's Changed - KMS Keys and Bucket Server-Side-Encryption by [@​tobikris](https://togithub.com/tobikris) in [aminueza/terraform-provider-minio#486 #### New Contributors - [@​tobikris](https://togithub.com/tobikris) made their first contribution in [aminueza/terraform-provider-minio#486 **Full Changelog**: aminueza/terraform-provider-minio@v1.15.3...v1.16.0 ### [`v1.15.3`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v1.15.3) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v1.15.2...v1.15.3) #### What's Changed - Fix an example value of `expiration` by [@​y-yagi](https://togithub.com/y-yagi) in [aminueza/terraform-provider-minio#462 - Fix group status handling by [@​asdevcapybara](https://togithub.com/asdevcapybara) in [aminueza/terraform-provider-minio#484 #### New Contributors - [@​y-yagi](https://togithub.com/y-yagi) made their first contribution in [aminueza/terraform-provider-minio#462 - [@​asdevcapybara](https://togithub.com/asdevcapybara) made their first contribution in [aminueza/terraform-provider-minio#484 **Full Changelog**: aminueza/terraform-provider-minio@v1.15.2...v1.15.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43LjAiLCJ1cGRhdGVkSW5WZXIiOiIzNi43LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix disable_group option in "minio_iam_group" resource
This PR fixing the issue in the resource
minio_iam_group.disable_groupoption did not work correctly, it did not update the group status in the MinIO, even if you set it to true or false.Reference
Closing issues