Allow Conan profiles #115
Merged
Allow Conan profiles #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddalcino any update on this? |
|
Requires rebase because of #122 |
# Conflicts: # src/Conan.cmake
|
I think this merge is right; it's hard to tell without good tests. |
aminya
approved these changes
Apr 28, 2022
|
The low-level test you are talking about should be done in conan-cmake. We are just calling it with the argument they defined. We can add a simple Conan profile in CI and test with that just for verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #114
Todo:
project_optionsthat implements this feature (unsuccessfully so far). I can tell you that this branch ofproject_optionspasses the profile properly into Conan, but I would prefer to prove it with a test.