New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow project options to be used in creation of a conan package. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ddalcino Could you review this? |
aminya
requested changes
Apr 20, 2022
The MacOS failure seems to be caused by llvm 14.0.0.
|
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
aminya
reviewed
Apr 26, 2022
aminya
requested changes
Apr 26, 2022
aminya
reviewed
Apr 26, 2022
Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled across this problem when using project options to build a library, that library could no longer be built via a conan recipe.
i have wrapped part of the conan.cmake to test if we are been built via
conan
and allow conan to define the build settings, rather than call ''conan_cmake_autodetect``you can find my test project library and recipe that shows the problem (currently calling my fork of project options) reverting back to current release should show the following issue.
gcc
conan create ./all 0.0.1@lambtonr/testing
clang
conan create ./all 0.0.1@lambtonr/testing
This is caused by the fact
conan_cmake_autodetect
will use different setting to conan GCC default profile matches that ofconan_cmake_autodetect
where as clangs defaults differ causing the issue.