Skip to content

Commit

Permalink
fix: fix missing fs/promises and isexe on old Node versions
Browse files Browse the repository at this point in the history
  • Loading branch information
aminya committed Sep 7, 2023
1 parent f2d0593 commit 9c7c626
Show file tree
Hide file tree
Showing 9 changed files with 72 additions and 71 deletions.
19 changes: 4 additions & 15 deletions dev/docker/__tests__/ubuntu.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,11 @@ COPY "./dist/legacy" "/usr/lib/setup-cpp/"

RUN apt-get update -qq && \
# install nodejs
apt-get install -y --no-install-recommends nodejs npm && \
apt-get install -y --no-install-recommends nodejs npm

# install the compiler and tools
node /usr/lib/setup-cpp/setup-cpp.js \
--nala true \
--compiler llvm \
--cmake true \
--ninja true \
--task true \
--vcpkg true \
--python true \
--make true \
--cppcheck true \
--gcovr true \
--doxygen true \
--ccache true && \
RUN node /usr/lib/setup-cpp/setup-cpp.js \
--gcovr true && \
# cleanup
nala autoremove -y && \
nala autopurge -y && \
Expand Down
30 changes: 15 additions & 15 deletions dist/actions/setup-cpp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/actions/setup-cpp.js.map

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions dist/legacy/setup-cpp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/legacy/setup-cpp.js.map

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions dist/modern/setup-cpp.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/modern/setup-cpp.js.map

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
"eslint-config-atomic": "^1.19.3",
"exec-powershell": "workspace:*",
"execa": "^7.2.0",
"fs-extra": "^11.1.1",
"is-url-online": "^1.5.0",
"jest": "^29.6.4",
"micro-memoize": "^4.1.2",
Expand Down Expand Up @@ -143,6 +144,7 @@
"escape-string-regexp",
"exec-powershell",
"execa",
"fs-extra",
"is-url-online",
"micro-memoize",
"mri",
Expand Down Expand Up @@ -184,12 +186,14 @@
"alias": {
"electron": false,
"patha": "patha/dist/index.node.mjs",
"admina": "admina/dist/index.mjs"
"admina": "admina/dist/index.mjs",
"fs/promises": "fs-extra/lib/esm.mjs"
},
"pnpm": {
"overrides": {
"whatwg-url": "^12",
"semver": "^7.5.4"
"semver": "^7.5.4",
"isexe": "^2"
}
},
"targets": {
Expand Down
20 changes: 14 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9c7c626

Please sign in to comment.