-
Notifications
You must be signed in to change notification settings - Fork 483
Conversation
- Use 'express()' instead of 'express.createServer()' - Use `path.existsSync` instead of `fs.existsSync` - Remove trailing whitespaces - Add travis CI.
Should also fix #50. |
@amir20 until this gets pulled, how can I use it in my app? |
@kent You can update your
|
Thanks! |
I've worked from this branch to add argument passing when evaluating statements if you're at all interested. https://github.com/edgecampus/phantomjs-node/tree/edgecampus |
Frustrating that this issue has been open for so long despite the pull requests. I had to write my own implementation to get this. If you really need this in a node ap, check out https://npmjs.org/package/phantom-proxy |
@juriejan I can merge your pull request in to mine also. I have been keeping up with this. |
Cool. Let me know if you need anything from me. I'm adding small things here and there. Check the messages when deciding what you'd like to add. |
@juriejan I merged this with my branch. You should be able to point to my branch and get all the changes that I have merged and yours. |
Any reason this pull request has not yet been merged into master? |
I don't think the owner is maintaining anymore. |
If that's the case I vote we have the npm module switched to someone who is willing to maintain it under the name "phantom" https://github.com/sgentle/phantomjs-node/issues/57 |
I agree. Right now I have been doing this on my own branch. I might just re-release it under another name. |
It's a shame because @sgentle definitely seems to be alive and active according to https://github.com/sgentle?tab=activity In the meantime, I've had some success using https://github.com/sheebz/phantom-proxy instead, although it doesn't seem to be as deterministic as this project (that might be my fault though). |
still having problems when using this 1.7 fix relating to issue #31 on ubuntu 12.04 |
Thanks to @amir20 - this helped a lot! |
@asaaki You are welcome! |
Thank you - this pull request saved my project! 😄 - please merge this if you have a chance @sgentle |
@amir20 Note, if you check "Files changed", you've accidentally (I assume) versioned the node_modules directory containing upstream modules and dependencies. .gitignore should be updated if necessary, and the node_modules directory should be removed from the repository. This makes it difficult to see exactly what this Pull Request is actually changing. |
@jokeyrhyme Yea I noticed that too this morning. I will do a |
@jokeyrhyme Fixed now. |
Just a note to all that at this point the coffee script is not in sync with the js anymore. I tried doing |
"You can update your package.json file to my branch." I'm just getting started with node and haven't done this before, can you explain what I need to do a bit more? Thanks. |
Thank you this pull worked smoothly. |
Is there a fork that is published to npm? @sgentle |
@amir20 firstly, thanks for your work. secondly, i too have been having syncing problems with js vs coffee (in sgentle's repository, not your fork). in some cases i do a fresh npm install and get an old version of shim.js which does not match what is in the repository. on other machines, i get the latest. ironically, when the machine gets an outdated version of shim.js it works seemingly fine with Phantom 1.8. unfortunately, i can't make this happen consistently, so now i am looking to your branch. i realize this is a strange issue. that said, unfortunately i am receiving an error with your fork:
have you seen this before? it's very possible it's something specific to my implementation: i am running many phantom processes across many child processes. as such, i actually had to submit a pull request of my own to make it work. i was only able to test your branch by merging it with my own. after merging, i recompiled phantom.coffee. did you make changes to phantom.js and not phantom.coffee that my compilation would have overrode? or, have you ever seen this error before? i realize this could have arisen from merging both our changes so if i am wasting your time i apologize. :) |
@ericstob No it is not published. I created https://github.com/amir20/phantomjs-node/issues/1 and will plan on deploying it to npm. For now use my branch. @catshirt I have never seen that error. Honestly, I just started merging people's pull requests because @sgentle didn't. |
Who is maintaining the module now? Where can i get one with all the fixes? |
I used phantoms webdriver interface instead, that bypassed all these
|
Which component/package did you use? On Fri, Jan 25, 2013 at 4:40 PM, Eric Stob notifications@github.com wrote:
|
@akhil you can use the one from my branch. I should have time soon to push to npm. For now just use the branch. |
Hello everybody, sorry for the delay. I have deployed my version of this module to npm. The new name is |
I have confirmed that this works with latest version of node |
https://github.com/amir20/phantomjs-node-v2 doesn't exist, nor does 'phantom-v2' in npm. I assume they were merged into the offical phantom package and the official repo. |
@reverie yes it has been merged to this repo and deployed to npm. |
This is an option pull request that merges two other pull request to fix bugs. I am using this for my own projects.