Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of dependent package "@discordjs/opus" #92

Closed
kokarare1212 opened this issue Nov 14, 2021 · 9 comments
Closed

Update of dependent package "@discordjs/opus" #92

kokarare1212 opened this issue Nov 14, 2021 · 9 comments

Comments

@kokarare1212
Copy link

Issue:

It uses the dependency package "ansi-regex" (GHSA-93q8-gq69-wqmw),
which is vulnerable due to an outdated version of the dependency package "@discordjs/opus".
The version of the dependent package "@discordjs/opus" needs to be updated.

# npm audit report

ansi-regex  >2.1.1 <5.0.1
Severity: moderate
 Inefficient Regular Expression Complexity in chalk/ansi-regex - https://github.com/advisories/GHSA-93q8-gq69-wqmw
fix available via `npm audit fix`
node_modules/ansi-regex
  strip-ansi  4.0.0 - 5.2.0
  Depends on vulnerable versions of ansi-regex
  node_modules/strip-ansi
    string-width  2.1.0 - 4.1.0
    Depends on vulnerable versions of strip-ansi
    node_modules/string-width
`-- @discordjs/opus@0.5.3
  `-- @discordjs/node-pre-gyp@0.4.2
    `-- npmlog@5.0.1
      `-- gauge@3.0.1
        `-- strip-ansi@4.0.0
          `-- ansi-regex@3.0.0

Further details:

@fredkilbourn
Copy link

This issue is further upstream and needs to be fixed first: discordjs/node-pre-gyp#5

@fredkilbourn
Copy link

The current versions of @discordjs/opus are also vulnerable. Once @discordjs/node-pre-gyp is fixed @discordjs/opus will also need to reference that fix. Once that happens prism-media can pull in the update.

@kokarare1212
Copy link
Author

Yes, I understand.
I will wait until a fixed version is released.

@darahask
Copy link

@fredkilbourn any update on this issue?

@fredkilbourn
Copy link

I think they fixed it a while ago...

@sasjafor
Copy link

sasjafor commented Jul 5, 2022

What exactly is this waiting on? Locally running npm i with @discordjs/opus updated to 0.8.0 seems to work. Can I create a PR to get this finally resolved?

@fredkilbourn
Copy link

This issue is referencing an issue from last year, not related to the CVE from this month.

@fredkilbourn
Copy link

Opened an issue for the new CVE: #105

This issue #92 should be closed.

@amishshah
Copy link
Owner

Fixed in v1.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants