non breaking refactors #1314
Merged
non breaking refactors #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nschejtman
commented
Feb 15, 2022
nschejtman
commented
- Moved avoidError from ModelTraversalRegistry to RecursionErrorRegister
- Split ShapeTraversalRegistry from ModelTraversalRegistry with Shape specific logic
- Refactor: aggregate allowList logic into allow method
- Some refactors: - Split recursionAndError method into single responsibility method calls - Rename RegisterCriteria -> ThrowRecursionValidationCriteria (more specific) - Rename shouldFailIfRecursive -> foundRecursion (does not necessarily fail) - Rename recursionError -> checkRecursionError (checks if an error should be thrown)
- Add some TODO comments with required refactors
- Split recursionAndError method into single responsibility method calls - Rename RegisterCriteria -> ThrowRecursionValidationCriteria (more specific) - Rename shouldFailIfRecursive -> foundRecursion (does not necessarily fail) - Rename recursionError -> checkRecursionError (checks if an error should be thrown)
nschejtman
force-pushed
the
non-breaking-refactors
branch
from
7e168b3
to
2ce235b
Compare
tomsfernandez
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.