-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the loading UI for auth flow #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amlan-roy
added a commit
that referenced
this pull request
Apr 8, 2024
* fix: fix bug in generate variant page (#79) * fix: remove unused code used for debugging (#80) * fix: gen variant page issue (#82) * Revert "fix: gen variant page issue (#82)" (#83) This reverts commit 649551c. * fix: removed the logic from middleware and added directly in page (#84) * Revert 81 master (#85) * v0.9.1 (#76) * minor fix (#75) * minor fix * fix * Bump undici and firebase (#74) Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together. Updates `undici` from 5.26.5 to 5.28.3 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.5...v5.28.3) Updates `firebase` from 10.8.0 to 10.8.1 - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: firebase dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v0.9.2 (#78) * minor fix (#75) * minor fix * fix * Bump undici and firebase (#74) Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together. Updates `undici` from 5.26.5 to 5.28.3 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.5...v5.28.3) Updates `firebase` from 10.8.0 to 10.8.1 - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: firebase dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 0.9.3 (#81) * minor fix (#75) * minor fix * fix * Bump undici and firebase (#74) Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together. Updates `undici` from 5.26.5 to 5.28.3 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.5...v5.28.3) Updates `firebase` from 10.8.0 to 10.8.1 - [Release notes](https://github.com/firebase/firebase-js-sdk/releases) - [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md) - [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1) --- updated-dependencies: - dependency-name: undici dependency-type: indirect - dependency-name: firebase dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com> * fix: fix bug in generate variant page (#79) * fix: remove unused code used for debugging (#80) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert "0.9.3 (#81)" This reverts commit dda048f. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Revert "Revert 81 master (#85)" (#86) This reverts commit 984f940. * updated snapshots (#88) * debug: refresh instead of push (#89) Not sure if this will fix the issue of not navigating to the home page on successful login. Not able to test this here, so will have to test in prod (YOLO) * Fix login issue (#92) * fix: nav issue in home page variant button * use refresh instead of push * doc: added comments * Bump jose from 4.15.4 to 4.15.5 (#94) Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md) - [Commits](panva/jose@v4.15.4...v4.15.5) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump follow-redirects from 1.15.5 to 1.15.6 (#95) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor imports (#98) * added prettierrc, trivago auto sort and format script in package json * ran prettier command for all files * Update templates (#100) * doc: updated and added issue templates * infra: added pr description check action * Add loading (#101) * feat: added box-loader component * tests: added test for box-loader * feat: added loading page * infra: updated pr description * Refactor auth (#103) * refactor: move out the logout function and update its usages * test: added logout test * chore: Added useLogin hook and tests for it * chore: Added useSignup hook and tests for it * refactor: use the auth hooks in login and signup pages * refactor: removed the auth footer * test: added setup to hide onsole error messages * test: mock firebase config * test: mock firebase config * test: mock firebase config * test: mock firebase config * feat: fix the loading UI for auth flow (#105) * feat: guarded the resume generation for people with verified email (#107) * fix: fix the loading state of the auth flow (#108) - The loading of login/auth stops after the auth, and there is a small delay before tansition to the home page. - Fixed the flow to keep the loading state when authState is loading or authenticated to mitigate this extra delay * feat: added email verification banner and button (#110) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #104
Summary
Made style updates
Testing done
Tested the UI locally.
Tests pass.
Checklist: