Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the loading state of the auth flow #108

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix: fix the loading state of the auth flow #108

merged 1 commit into from
Apr 7, 2024

Conversation

amlan-roy
Copy link
Owner

@amlan-roy amlan-roy commented Apr 7, 2024 •
edited
Loading

Issue: #102

Summary

  • The loading of login/auth stops after the auth, and there is a small delay before tansition to the home page.
  • Fixed the flow to keep the loading state when authState is loading or authenticated to mitigate this extra delay

Testing done

  • Tested the UI
  • Existing tests pass
  • Will need to add more tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@amlan-roy
fix: fix the loading state of the auth flow
646283a 
- The loading of login/auth stops after the auth, and there is a small
  delay before tansition to the home page.
- Fixed the flow to keep the loading state when authState is loading or
  authenticated to mitigate this extra delay
@vercel Vercel
Copy link

vercel bot commented Apr 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
resume-craft ✅ Ready (Inspect) Visit Preview Apr 7, 2024 0:47am

@amlan-roy amlan-roy self-assigned this Apr 7, 2024
@amlan-roy amlan-roy merged commit d945acb into master Apr 7, 2024
5 checks passed
@amlan-roy amlan-roy deleted the auth-flow-fix branch April 7, 2024 12:49
amlan-roy added a commit that referenced this pull request Apr 8, 2024
@amlan-roy @dependabot
V0.9.4.3 (#111)
59662b9 
* fix: fix bug in generate variant page (#79)

* fix: remove unused code used for debugging (#80)

* fix: gen variant page issue (#82)

* Revert "fix: gen variant page issue (#82)" (#83)

This reverts commit 649551c.

* fix: removed the logic from middleware and added directly in page (#84)

* Revert 81 master (#85)

* v0.9.1 (#76)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* v0.9.2 (#78)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 0.9.3 (#81)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

* fix: fix bug in generate variant page (#79)

* fix: remove unused code used for debugging (#80)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "0.9.3 (#81)"

This reverts commit dda048f.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "Revert 81 master (#85)" (#86)

This reverts commit 984f940.

* updated snapshots (#88)

* debug: refresh instead of push (#89)

Not sure if this will fix the issue of not navigating to the home page on successful login. Not able to test this here, so will have to test in prod (YOLO)

* Fix login issue (#92)

* fix: nav issue in home page variant button

* use refresh instead of push

* doc: added comments

* Bump jose from 4.15.4 to 4.15.5 (#94)

Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md)
- [Commits](panva/jose@v4.15.4...v4.15.5)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump follow-redirects from 1.15.5 to 1.15.6 (#95)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactor imports (#98)

* added prettierrc, trivago auto sort and format script in package json

* ran prettier command for all files

* Update templates (#100)

* doc: updated and added issue templates

* infra: added pr description check action

* Add loading (#101)

* feat: added box-loader component

* tests: added test for box-loader

* feat: added loading page

* infra: updated pr description

* Refactor auth (#103)

* refactor: move out the logout function and update its usages

* test: added logout test

* chore: Added useLogin hook and tests for it

* chore: Added useSignup hook and tests for it

* refactor: use the auth hooks in login and signup pages

* refactor: removed the auth footer

* test: added setup to hide onsole error messages

* test: mock firebase config

* test: mock firebase config

* test: mock firebase config

* test: mock firebase config

* feat: fix the loading UI for auth flow (#105)

* feat: guarded the resume generation for people with verified email (#107)

* fix: fix the loading state of the auth flow (#108)

- The loading of login/auth stops after the auth, and there is a small
  delay before tansition to the home page.
- Fixed the flow to keep the loading state when authState is loading or
  authenticated to mitigate this extra delay

* feat: added email verification banner and button (#110)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amlan-roy amlan-roy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@amlan-roy