-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip git-based version if building from tarballs #226
Conversation
I am not sure, isn't it enough to just set |
Setting |
I'd prefer to set |
This allows downstream distributions to builds from tarballs which lack any git metadata. See: ammen99#226
78e5dc4
to
6d0afc0
Compare
Tested via: mv .git _git
meson build
meson compile -C build
mv _git .git
git clean -xdf
meson build
meson compile -C build |
Please write out |
6d0afc0
to
8f9f058
Compare
Done |
This allows downstream distributions to builds from tarballs which lack any git metadata. See: ammen99#226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This allows downstream distributions to builds from tarballs which lack any git metadata.