Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip git-based version if building from tarballs #226

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

WhyNotHugo
Copy link
Contributor

This allows downstream distributions to builds from tarballs which lack any git metadata.

@ammen99
Copy link
Owner

ammen99 commented Aug 23, 2023

I am not sure, isn't it enough to just set check: false in the git commands?

@WhyNotHugo
Copy link
Contributor Author

Setting check: false would work. I don't have much context as to why this was changed; it happened in #193

@ammen99
Copy link
Owner

ammen99 commented Aug 23, 2023

I'd prefer to set check: false then, we do a check whether the command succeeds anyway.

WhyNotHugo added a commit to WhyNotHugo/wf-recorder that referenced this pull request Aug 23, 2023
This allows downstream distributions to builds from tarballs which lack
any git metadata.

See: ammen99#226
@WhyNotHugo
Copy link
Contributor Author

Tested via:

mv .git _git
meson build
meson compile -C build
mv _git .git
git clean -xdf
meson build
meson compile -C build

@ammen99
Copy link
Owner

ammen99 commented Aug 23, 2023

Please write out check: false explicitly :)
Otherwise lgtm.

@WhyNotHugo
Copy link
Contributor Author

Done

This allows downstream distributions to builds from tarballs which lack
any git metadata.

See: ammen99#226
Copy link
Owner

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit f165b35 into ammen99:master Aug 23, 2023
1 check passed
@WhyNotHugo WhyNotHugo deleted the build-from-tarballs branch August 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants