Skip to content
This repository has been archived by the owner on Jun 24, 2023. It is now read-only.

Fix typo in exception #9

Merged
merged 1 commit into from
May 23, 2012
Merged

Fix typo in exception #9

merged 1 commit into from
May 23, 2012

Conversation

Ikke
Copy link
Contributor

@Ikke Ikke commented May 22, 2012

resolve_conf -> resolv_conf

resolve_conf -> resolv_conf
amoffat pushed a commit that referenced this pull request May 23, 2012
Fix typo in exception
@amoffat amoffat merged commit 56db6bc into amoffat:master May 23, 2012
@amoffat
Copy link
Owner

amoffat commented May 23, 2012

good catch! that damned missing "e"... :)

@Ikke
Copy link
Contributor Author

Ikke commented May 23, 2012

I found out because when I started this program on boot, it still
didn't have any nameservers set up, and it gave an exception that it
couldn't find the name.

I'm also busy with an option to let the program wait until the
nameservers are set, but I haven't fully tested it yet.

On Wed, May 23, 2012 at 3:01 AM, Andrew Moffat
reply@reply.github.com
wrote:

good catch!  that damned missing "e"... :)


Reply to this email directly or view it on GitHub:
#9 (comment)

@amoffat
Copy link
Owner

amoffat commented May 23, 2012

@Ikke sounds good. One thing you might try adding (if you're up for it) is a command line option for a specific failover nameserver. It can be optional, and in the case that the user provides it, it won't complain about resolv.conf not having any other nameservers.

@Ikke
Copy link
Contributor Author

Ikke commented May 23, 2012

It's easy enough. I'll add it.

On Wed, May 23, 2012 at 9:41 AM, Andrew Moffat
reply@reply.github.com
wrote:

@Ikke sounds good.  One thing you might try adding (if you're up for it) is a command line option for a specific failover nameserver.  It can be optional, and in the case that the user provides it, it won't complain about resolv.conf not having any other nameservers.


Reply to this email directly or view it on GitHub:
#9 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants