Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dukpy usable when installed. #5

Merged
merged 3 commits into from
Jun 21, 2016
Merged

Conversation

amcgregor
Copy link
Contributor

Currently the tests pass because the package is installed via setup.py develop (indirectly, via pip install -e .) in travis.yml, which does not match a "user environment" where the package is installed normally via the Python Package Index, and bypasses a bug whereby the package_data directive in setup.py was incorrectly assuming recursive descent in the wildcard *.js declaration. The error exhibited as an inability for the installation utility to resolve the semver module, since the jsmodules tree was not installed.

This pull request corrects this issue, making the package usable when installed, not just when checked out and "installed in place". Additionally, it shortens some typing; instead of pip install -e . or python setup.py develop, now users on UN*X-like systems can just type ./setup.py develop. :)

@coveralls
Copy link

coveralls commented Jun 21, 2016

Coverage Status

Coverage remained the same at 99.574% when pulling 81351b8 on illico:feature/installable into 409651b on amol-:master.

@amol-
Copy link
Owner

amol- commented Jun 21, 2016

Thanks! That's something I missed when I moved all the js files inside subdirectories during last release :/

@amol- amol- merged commit fdbacb2 into amol-:master Jun 21, 2016
@amol-
Copy link
Owner

amol- commented Jun 21, 2016

released as 0.0.4

@amcgregor amcgregor deleted the feature/installable branch June 21, 2016 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants