Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests so that they don't rely on specific credentials #23

Merged
merged 33 commits into from
Feb 18, 2019
Merged

Update tests so that they don't rely on specific credentials #23

merged 33 commits into from
Feb 18, 2019

Conversation

espoem
Copy link
Contributor

@espoem espoem commented Feb 17, 2019

Running tests locally required specific credentials for fpl.login() method. Mocking was introduced to abstract the logic of fetching data and a few methods' logic was fixed according to the docs.

@espoem
Check that user_id is a positive number
dceefb2
@espoem
Change team_ids default type
3f5fcf4
@espoem
Add check on team id
da54fd9
@espoem
Add assertion on non negative player id for player summary
6d73b4c
@espoem
Change signature of get_player_summaries
908e291
@espoem
Check if a player is found in fpl.get_player
2149764
@espoem
Change player_ids default to None in get_players
caa13c3
@espoem
Add checks on unknown fixture ids in get_fixture
8df8146
@espoem
Return empty list on empty fixture ids in get_fixtures_by_id
30861e7
@espoem
Check email password is set
55f0179
@espoem
Update test_fpl
a78281d
@espoem
Exctract AsyncMock to helper module
7b2fff8
@espoem
Update test_classic_league
2b7ea75
@espoem
Add safe attribute calls to Fixture
316c5ee
@espoem
Update Fixture tests
d29623d
@espoem
Add check on gameweek with id not found
ebc2c5c
@espoem
Add safe attr calls to player
e289c0f
@espoem
Add helper func to check logged in user
813f918
@espoem
Check login in get_fixtures
b83e37d
@espoem
Update h2h_league tests
c5b2f09
@espoem
Move fixture test data to test_fixture
4fc8319
@espoem
Update valid_gameweek
f958c98
@espoem
Fix user.get_season_history
3dbe312
@espoem
Return flattened list of picks in user.get_picks
cfec4b0
@espoem
Update test_user
85f138c
@espoem
Return flattened list in get_automatic_substitutions
7c42987
@espoem
Fix check on authenticated user session in User class
e335bf9
@espoem
Add more tests to test_user
850e553
@espoem
Fix get_transfers caching logic
1e70f9d
@espoem
Add tests to test_user
2c97eda
amosbastian
amosbastian requested changes Feb 18, 2019
View reviewed changes
Copy link
Owner

@amosbastian amosbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and it's perfect imo. Great work making everything more robust and adding some great tests (especially since you don't even play FPL yourself)!

tests/test_fixture.py Outdated Show resolved Hide resolved
tests/test_h2h_league.py Outdated Show resolved Hide resolved
tests/test_h2h_league.py Show resolved Hide resolved
tests/test_user.py Outdated Show resolved Hide resolved
@amosbastian amosbastian merged commit d6948c1 into amosbastian:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amosbastian amosbastian amosbastian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@espoem @amosbastian