Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DI to existing credential via popup window #114

Closed
veitmo opened this issue Jun 7, 2022 · 9 comments
Closed

add DI to existing credential via popup window #114

veitmo opened this issue Jun 7, 2022 · 9 comments
Assignees
Labels
DONE Issue is done and merged into main. RP: 5 SP: 5

Comments

@veitmo
Copy link
Collaborator

veitmo commented Jun 7, 2022

User story

  1. As a {HR-employee}
  2. I want / need {to be able to add a DI to an existing credential}
  3. So that {I can create e.g. a Mitarbeiterausweis for that DI}

Acceptance criteria

  • pop-up window opens where HR-employee can select from the existing DIs
    • HR-employee needs to enter values for the attributes that the credential defines
    • send-button at bottom which triggers the assignment of a DI to a credential
  • After clicking send button, process runs through successfually and HR employee gets feedback on success/error in the frontend:
    • DI is really linked to credential
    • Credential information can be seen in Lissi Wallet

Note from SD meeting:

  • connections/all has to be adjusted: merge local database (name, surname, email) with lissi/api/connections/all
  • note: please implement a new controller in the backend called "CredentialController", which differs from the current "CredentialDefinitionController"

Definition of done (DoD)

  • code peer-reviewed (by at least one team member)
  • acceptance criteria met
  • integrated into a clean build
  • documentation updated
  • code is well-formatted (according to our norms) and structure
  • Code supports all functions/cases and all responses defined in the API
  • no severe bugs during main functionalities (program should not stop executing due to these bugs, e.g. runtime exception in Docker)
  • Bill of Materials updated if necessary
  • 70% of the tests pass
  • important functions shall be tested
  • code has been deployed via Docker to the server

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@veitmo veitmo added this to Product Backlog in Feature Backlog via automation Jun 7, 2022
@veitmo veitmo changed the title pop-up window for adding DI to existing credential adding DI to existing credential via popup window Jun 13, 2022
@veitmo veitmo changed the title adding DI to existing credential via popup window add DI to existing credential via popup window Jun 13, 2022
@hendhussienfau hendhussienfau moved this from Product Backlog to Sprint Backlog in Feature Backlog Jun 15, 2022
@jackDS008 jackDS008 moved this from Sprint Backlog to In progress in Feature Backlog Jun 18, 2022
@jackDS008
Copy link
Collaborator

@steve-237 Ich fange mal mit dem Backend an. Du kannst dann mit dem Frontend beginnen.

jackDS008 added a commit that referenced this issue Jun 20, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
jackDS008 added a commit that referenced this issue Jun 20, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
jackDS008 added a commit that referenced this issue Jun 20, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
jackDS008 added a commit that referenced this issue Jun 21, 2022
Added /credential/issue endpoint to OpenAPI and did some refactoring
@TamaraHoock TamaraHoock moved this from In progress to Product Backlog in Feature Backlog Jun 21, 2022
@TamaraHoock TamaraHoock moved this from Product Backlog to In progress in Feature Backlog Jun 21, 2022
@veitmo veitmo moved this from In progress to Sprint Backlog in Feature Backlog Jun 22, 2022
@jackDS008 jackDS008 moved this from Sprint Backlog to In progress in Feature Backlog Jun 22, 2022
jackDS008 added a commit that referenced this issue Jun 22, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
jackDS008 added a commit that referenced this issue Jun 22, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
Idontker added a commit that referenced this issue Jun 22, 2022
valentinBraeutigam added a commit that referenced this issue Jun 22, 2022
Idontker added a commit that referenced this issue Jun 27, 2022
…y alias of created connections

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 27, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 27, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
@jackDS008 jackDS008 moved this from In progress to Awaiting review in Feature Backlog Jun 27, 2022
jackDS008 added a commit that referenced this issue Jun 28, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
@Idontker Idontker self-assigned this Jun 28, 2022
@Idontker Idontker added the DONE Issue is done and merged into main. label Jun 28, 2022
@TamaraHoock TamaraHoock moved this from Awaiting review to Sprint Backlog in Feature Backlog Jun 29, 2022
@TamaraHoock TamaraHoock removed the DONE Issue is done and merged into main. label Jun 29, 2022
@TamaraHoock TamaraHoock moved this from Sprint Backlog to Product Backlog in Feature Backlog Jun 29, 2022
@veitmo veitmo moved this from Product Backlog to Sprint Backlog in Feature Backlog Jun 29, 2022
@annikakrause
Copy link
Collaborator

only test for backend @jackDS008 and frontend @steve-237 are missing

@jackDS008 jackDS008 moved this from Sprint Backlog to In progress in Feature Backlog Jul 1, 2022
@jackDS008 jackDS008 moved this from In progress to Sprint Backlog in Feature Backlog Jul 1, 2022
@jackDS008 jackDS008 moved this from Sprint Backlog to In progress in Feature Backlog Jul 2, 2022
jackDS008 added a commit that referenced this issue Jul 2, 2022
Signed-off-by: Jannik Kiesel <jannik.kiesel@fau.de>
@jackDS008
Copy link
Collaborator

Backend tests in pull requests #226

valentinBraeutigam added a commit that referenced this issue Jul 3, 2022
@jackDS008
Copy link
Collaborator

@steve-237 Wie weit bist du mit den Tests im Frontend?

@veitmo veitmo moved this from In progress to Sprint Backlog in Feature Backlog Jul 6, 2022
@steve-237
Copy link
Collaborator

steve-237 commented Jul 7, 2022

Ich bin damit durch

@annikakrause
Copy link
Collaborator

Ich bin damit durch

Kannst du dann dazu einen PR erstellen?

@steve-237
Copy link
Collaborator

Ich bin damit durch

Kannst du dann dazu einen PR erstellen?

ich hatte schon seit ein paar Tagen das auch gemacht und es wurde auch gereviewt

@annikakrause
Copy link
Collaborator

ich hatte schon seit ein paar Tagen das auch gemacht und es wurde auch gereviewt

Achso, super. Heißt das, alles zu diesem issue ist im main und das issue kann in awaiting review?

@steve-237
Copy link
Collaborator

ich hatte schon seit ein paar Tagen das auch gemacht und es wurde auch gereviewt

Achso, super. Heißt das, alles zu diesem issue ist im main und das issue kann in awaiting review?

Ja! Jannik wird das später machen

@steve-237 steve-237 moved this from Sprint Backlog to Awaiting review in Feature Backlog Jul 9, 2022
@veitmo veitmo moved this from Awaiting review to Feature archive in Feature Backlog Jul 13, 2022
@annikakrause annikakrause added the DONE Issue is done and merged into main. label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DONE Issue is done and merged into main. RP: 5 SP: 5
Projects
Feature Backlog
Feature archive
Development

No branches or pull requests

7 participants