Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DI on Adorsys Lissi Blockchain #166

Closed
TamaraHoock opened this issue Jun 21, 2022 · 1 comment · Fixed by #197 or #217
Closed

Delete DI on Adorsys Lissi Blockchain #166

TamaraHoock opened this issue Jun 21, 2022 · 1 comment · Fixed by #197 or #217
Assignees
Labels
DONE Issue is done and merged into main. RP: 8 SP: 3

Comments

@TamaraHoock
Copy link
Collaborator

TamaraHoock commented Jun 21, 2022

User story

  1. As a {HR-Employee}
  2. I want / need {to be able to delete an existing DI}
  3. So that {existing DIs are eliminated}

Acceptance criteria

  • Create a button designed with a "bucket" icon on the DI overview table on the right side in each column, to allow the deletion of one DI based on the selected column
  • Moving cursor above bucket should activate a description "Delete DI"
  • Clicking on bucket should activate a pop-up window:
    "Delete DI
    Are you sure you want to the delete the DI for {DI-name}?"
    • pop-up window should have a tick box "Yes, I want to delete the DI"
    • Pop-up window needs a delete button, that is colored grey (not yet activated) and can't be clicked on directly. Delete button can only be activated (colored in red), once the tick box is filed out.
    • Pop-up window needs a cancel button, that cancels this process and leads user back to DI overview table
  • feedback on success/error is displayed in frontend
  • pop-up window to inform hr-employee that DI was successfully deleted "The DI {DI-Name} was successfully deleted"
  • DI is fully deleted in Lissi and our database

Definition of done (DoD)

  • code peer-reviewed (by at least one team member)
  • acceptance criteria met
  • integrated into a clean build
  • documentation updated
  • code is well-formatted (according to our norms) and structure
  • Code supports all functions/cases and all responses defined in the API
  • no severe bugs during main functionalities (program should not stop executing due to these bugs, e.g. runtime exception in Docker)
  • Bill of Materials updated if necessary
  • 70% of the tests pass
  • important functions shall be tested
  • code has been deployed via Docker to the server

DoD general criteria

  • Feature has been fully implemented
  • Feature has been merged into the mainline
  • All acceptance criteria were met
  • Product owner approved features
  • All tests are passing
  • Developers agreed to release
@TamaraHoock TamaraHoock added this to Product Backlog in Feature Backlog via automation Jun 21, 2022
@jackDS008
Copy link
Collaborator

Discussion (Sprint Review 22.06.2022)

  • Should the user be deleted when the DI gets deleted?
  • Should the e-mail be unique or should it be possible to create more than one DI with the same e-mail?

@veitmo veitmo added the SP: 3 label Jun 22, 2022
@veitmo veitmo moved this from Product Backlog to Sprint Backlog in Feature Backlog Jun 22, 2022
@Idontker Idontker moved this from Sprint Backlog to In progress in Feature Backlog Jun 23, 2022
Idontker added a commit that referenced this issue Jun 23, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 23, 2022
…s it is not supported by the lissi api yet

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 23, 2022
…ored postForObject (now easier to use by using HttpService.postForObject)

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 24, 2022
… remove fails due to lissi api)

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 24, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 24, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 25, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 25, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 26, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 26, 2022
…hout the DIDentity app

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 26, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Idontker added a commit that referenced this issue Jun 26, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
@Idontker Idontker linked a pull request Jun 26, 2022 that will close this issue
@Idontker Idontker moved this from In progress to Awaiting review in Feature Backlog Jun 26, 2022
Idontker added a commit that referenced this issue Jun 26, 2022
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
@Idontker Idontker added DONE Issue is done and merged into main. RP: 8 labels Jun 27, 2022
@Idontker Idontker moved this from Awaiting review to Product Backlog in Feature Backlog Jun 29, 2022
@TamaraHoock TamaraHoock removed the DONE Issue is done and merged into main. label Jun 29, 2022
@veitmo veitmo moved this from Product Backlog to Sprint Backlog in Feature Backlog Jun 29, 2022
@Idontker Idontker moved this from Sprint Backlog to In progress in Feature Backlog Jun 30, 2022
@Idontker Idontker linked a pull request Jun 30, 2022 that will close this issue
@Idontker Idontker moved this from In progress to Awaiting review in Feature Backlog Jun 30, 2022
@veitmo veitmo moved this from Awaiting review to Feature archive in Feature Backlog Jul 6, 2022
@annikakrause annikakrause added the DONE Issue is done and merged into main. label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DONE Issue is done and merged into main. RP: 8 SP: 3
Projects
Feature Backlog
Feature archive
5 participants