-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
129 prefilled password change #177
Conversation
…assword mail Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
…afe for use within an url Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
reviewer might tell me whether I should create automatic tests for these lines of code. IMO: all I do is calling the API :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please mind spelling errors, if we approve them, it's harder to fix them later (e.g. "changePasswordPrefiled" vs. "changePasswordPrefilled", "Sie" with capital letters in the email...)
- the link itself doesn't work for now, it links to the device name without any port instead of "localhost:4200"
- prefill of the password fails when using some specific symbols like ". Example: Passwort:
§9@7w{Hd80Wul^~"?3y1
-> prefilled part:§9@7w{Hd80Wul^~
Spelling errors are an easy refactoring. Most IDEs support a quick and easy renaming. |
True. I think a similar issue lies within the HttpBackendService of the frontend. As we send all parameters within the URL / URI certain special characters will result in unwanted behavior. This will happen in login and change password I will fix the strong password now, but we might need to check whether this issue will occur within the login/change password process |
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
I do not encounter this issue :| Are you sure that you ve set them up correctly? I used:
|
Of course, but normally there should be no need for such refactoring ;) |
You are right, I forgot to change this after Jean's Docker changes, thanks! |
PM: @valentinBraeutigam