Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

129 prefilled password change #177

Merged
merged 8 commits into from
Jun 26, 2022
Merged

Conversation

Idontker
Copy link
Collaborator

…assword mail

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
…afe for use within an url

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
@Idontker Idontker linked an issue Jun 22, 2022 that may be closed by this pull request
@Idontker
Copy link
Collaborator Author

reviewer might tell me whether I should create automatic tests for these lines of code. IMO: all I do is calling the API :)

@Idontker Idontker self-assigned this Jun 22, 2022
@annikakrause annikakrause self-requested a review June 23, 2022 15:44
Copy link
Collaborator

@annikakrause annikakrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please mind spelling errors, if we approve them, it's harder to fix them later (e.g. "changePasswordPrefiled" vs. "changePasswordPrefilled", "Sie" with capital letters in the email...)
  • the link itself doesn't work for now, it links to the device name without any port instead of "localhost:4200"
  • prefill of the password fails when using some specific symbols like ". Example: Passwort:§9@7w{Hd80Wul^~"?3y1 -> prefilled part: §9@7w{Hd80Wul^~

@Idontker
Copy link
Collaborator Author

  • please mind spelling errors, if we approve them, it's harder to fix them later (e.g. "changePasswordPrefiled" vs. "changePasswordPrefilled", "Sie" with capital letters in the email...)

Spelling errors are an easy refactoring. Most IDEs support a quick and easy renaming.

@Idontker
Copy link
Collaborator Author

  • prefill of the password fails when using some specific symbols like ". Example: Passwort:§9@7w{Hd80Wul^~"?3y1 -> prefilled part: §9@7w{Hd80Wul^~

True. I think a similar issue lies within the HttpBackendService of the frontend. As we send all parameters within the URL / URI certain special characters will result in unwanted behavior. This will happen in login and change password

I will fix the strong password now, but we might need to check whether this issue will occur within the login/change password process

Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
@Idontker
Copy link
Collaborator Author

  • the link itself doesn't work for now, it links to the device name without any port instead of "localhost:4200"

I do not encounter this issue :|
The url is pulled from the application .properties frontend.host.url.change.password

Are you sure that you ve set them up correctly? I used:

frontend.host.url.change.password=http://localhost:4200/password/change

@annikakrause
Copy link
Collaborator

  • please mind spelling errors, if we approve them, it's harder to fix them later (e.g. "changePasswordPrefiled" vs. "changePasswordPrefilled", "Sie" with capital letters in the email...)

Spelling errors are an easy refactoring. Most IDEs support a quick and easy renaming.

Of course, but normally there should be no need for such refactoring ;)

@annikakrause
Copy link
Collaborator

  • the link itself doesn't work for now, it links to the device name without any port instead of "localhost:4200"

I do not encounter this issue :| The url is pulled from the application .properties frontend.host.url.change.password

Are you sure that you ve set them up correctly? I used:

frontend.host.url.change.password=http://localhost:4200/password/change

You are right, I forgot to change this after Jean's Docker changes, thanks!

@annikakrause annikakrause merged commit 18cbbf7 into main Jun 26, 2022
@annikakrause annikakrause deleted the 129-prefilled-password-change branch June 26, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefilled formular on initial password change
2 participants