Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 overview pages style #262

Merged
merged 6 commits into from
Jul 12, 2022
Merged

44 overview pages style #262

merged 6 commits into from
Jul 12, 2022

Conversation

annikakrause
Copy link
Collaborator

Applied mock-up style to overview pages, set up for future styling is done. Colors are approved by POs.
Includes also #207.

RM: @annikakrause

annikakrause and others added 5 commits July 9, 2022 15:33
Signed-off-by: Annika Krause <annika.krause@fau.de>
Co-authored-by: valentinBraeutigam <104430118+valentinBraeutigam@users.noreply.github.com>
Signed-off-by: Annika Krause <annika.krause@fau.de>
Co-authored-by: annikakrause <104464769+annikakrause@users.noreply.github.com>
Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
…tyled all buttons equally

Co-authored-by: valentinBraeutigam <104430118+valentinBraeutigam@users.noreply.github.com>
Signed-off-by: Annika Krause <annika.krause@fau.de>
Co-authored-by: valentinBraeutigam <104430118+valentinBraeutigam@users.noreply.github.com>
Signed-off-by: Annika Krause <annika.krause@fau.de>
Copy link
Collaborator

@steve-237 steve-237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !!

@steve-237
Copy link
Collaborator

Capture d’écran 2022-07-11 211005
Capture d’écran 2022-07-11 211152
These two icons are supposed to give details, why didn't you use the same icons?

@steve-237
Copy link
Collaborator

Capture
Capture2
The styles here are different it would have been better to have the same styles

Copy link
Collaborator

@steve-237 steve-237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Nice colors and icons, the software is prettier : )

Signed-off-by: Jean28518 <jean-frederic.vog.vogelbacher@fau.de>
@Jean28518 Jean28518 merged commit 6498db6 into main Jul 12, 2022
@annikakrause
Copy link
Collaborator Author

Capture d’écran 2022-07-11 211005 Capture d’écran 2022-07-11 211152 These two icons are supposed to give details, why didn't you use the same icons?

The description before was different, once "details" and once "expand". But after your issue #240, the functionality is equal, so you are right, I will have a look at it :)

@annikakrause
Copy link
Collaborator Author

The styles here are different it would have been better to have the same styles

Yes, but that is a bit tricky and not part of our task as the pop-up styling is not included in this issue :)

@Idontker Idontker deleted the 44-overview-pages-style branch July 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants