243 automatically issue credential backend #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
…sted attributes not created Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Signed-off-by: Karol Bakas <karol.bakas@fau.de>
Jean28518
reviewed
Jul 14, 2022
There was a problem hiding this comment.
Looks very good!
but I get an error after trying... Don't know, if I've done all correctly I testet it with AutoIssueFinal
Do you have any ideas?
backend_1 | 2022-07-14 16:15:13.532 INFO 40 --- [ scheduling-1] d.a.d.services.ScheduledJobService : =================
backend_1 | 2022-07-14 16:15:13.532 INFO 40 --- [ scheduling-1] d.a.d.services.ScheduledJobService : checking for jobs
backend_1 | 2022-07-14 16:15:13.540 INFO 40 --- [ scheduling-1] d.a.d.services.HttpService : --
backend_1 | 2022-07-14 16:15:13.540 INFO 40 --- [ scheduling-1] d.a.d.services.HttpService : Sending uri-request to: GET https://onboardingad.ddns.net/ctrl/api/v1.0/presentation-proof/37fa9143-cc27-4e90-acd6-ec013287be72?id=37fa9143-cc27-4e90-acd6-ec013287be72
backend_1 | 2022-07-14 16:15:13.699 INFO 40 --- [ scheduling-1] d.a.d.services.HttpService : <<
backend_1 | 2022-07-14 16:15:13.699 INFO 40 --- [ scheduling-1] d.a.d.services.HttpService : Response: 200 - 200 OK
backend_1 | 2022-07-14 16:15:13.709 ERROR 40 --- [ scheduling-1] o.s.s.s.TaskUtils$LoggingErrorHandler : Unexpected error occurred in scheduled task
backend_1 |
backend_1 | java.lang.NullPointerException: Cannot invoke "didentity.amos.digitalIdentity.messages.responses.proofs.presentation.Attribute.getValue()" because the return value of "java.util.Map.get(Object)" is null
backend_1 | at didentity.amos.digitalIdentity.services.AutoIssueService.fillOutLinkedAttributeMapping(AutoIssueService.java:167) ~[classes/:na]
backend_1 | at didentity.amos.digitalIdentity.services.AutoIssueService.autoIssueCredential(AutoIssueService.java:131) ~[classes/:na]
backend_1 | at didentity.amos.digitalIdentity.services.AutoIssueService.handleSingleAutoIssue(AutoIssueService.java:110) ~[classes/:na]
backend_1 | at didentity.amos.digitalIdentity.services.AutoIssueService.handleAutoIssueActions(AutoIssueService.java:58) ~[classes/:na]
backend_1 | at didentity.amos.digitalIdentity.services.ScheduledJobService.checkActiveJobs(ScheduledJobService.java:32) ~[classes/:na]
backend_1 | at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) ~[na:na]
backend_1 | at java.base/java.lang.reflect.Method.invoke(Method.java:577) ~[na:na]
backend_1 | at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:84) ~[spring-context-5.3.19.jar:5.3.19]
backend_1 | at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54) ~[spring-context-5.3.19.jar:5.3.19]
backend_1 | at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[na:na]
backend_1 | at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) ~[na:na]
backend_1 | at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) ~[na:na]
backend_1 | at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[na:na]
backend_1 | at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[na:na]
backend_1 | at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]
Comment on lines
-67
to
75
| System.out.println("--"); | ||
| System.out.println("Sending request to:\t" + method + " " + url); | ||
| System.out.println("responseType:\t\t" + responseType); | ||
| System.out.println("With params:\t\t " + Arrays.toString(params)); | ||
| logger.info("--"); | ||
| logger.info("Sending media-request to:\t" + method + " " + url); | ||
| logger.debug("responseType:\t\t" + responseType); | ||
| logger.debug("With params:\t\t " + Arrays.toString(params)); | ||
| // bulild header |
|
Is there any update on this PR? :) |
|
@Idontker Soll ich da jetzt auch nochmal drüber schauen? @Jean28518 hat es bereits gereviewed, oder? Oder nur Teile davon? |
|
Ich habe alles reviewed, vom Code her habe ich keine Beanstandung :) |
Kannst du dann offiziell dein approve daruntersetzen und das Ganze mergen? :) |
valentinBraeutigam
deleted the
243-automatically-issue-credential-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should finish #243
Tests are missing and some minor improvements could be made. Nethertheless, I would recommend merge it now. This way multiple ppl could help finish this huge task.
RM @Jean28518