Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix table filter #278

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Bugfix table filter #278

merged 2 commits into from
Jul 18, 2022

Conversation

valentinBraeutigam
Copy link
Collaborator

Fixes the bug when filtering tables which contain undefined values
RM : @Jean28518

Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
@steve-237 steve-237 self-assigned this Jul 17, 2022
@steve-237 steve-237 self-requested a review July 18, 2022 07:40
Copy link
Collaborator

@steve-237 steve-237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We no longer have an error message in the console. Filtering works well but after removing the filter the attributes of the column chosen for filtering with undefined values ​​are no longer displayed.

@steve-237 steve-237 merged commit 57530ed into main Jul 18, 2022
@steve-237 steve-237 deleted the bugfixTableFilter branch July 18, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants