Improve error messages, add new error message service #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean28518 <jean-frederic.vog.vogelbacher@fau.de>
annikakrause
approved these changes
Jul 23, 2022
src/digitalIdentity-frontend/src/app/services/error-message-service/error-message.service.ts
Outdated
Show resolved
Hide resolved
src/digitalIdentity-frontend/src/app/services/error-message-service/error-message.service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Annika Krause <annika.krause@fau.de>
annikakrause
deleted the
258-display-more-precise-error-messages-eg-when-trying-to-log-in-with-not-existing-mail-adress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean28518 jean-frederic.vog.vogelbacher@fau.de
Wenn ich beispielsweise ein neues Schema mit unerlaubten Zeichen erstellen will, kommt nun aktuell die angepasste Fehlermeldung:
Möchte ich als User allerdings wissen, warum wirklich das Schema nicht erstellt wurde: Müsste ich im Backend das handleResponse() umbauen, weil es nämlich bei Fehlercodes, die eigentliche message vom Lissi Agent löscht, in dem es nur null zurück gibt. Wollen wir also mehr Info, warum das seitens des Lissi Agent nicht geklappt hat, dem User anzeigen, müssten wie überall das handle Response bearbeiten.
Ist bspw. unser Server nicht erreichbar, wird natürlich eine andere Fehlermeldung, als "Could not create a schema" angezeigt... Habe das nicht hartgecodet, ist dynamisch vom Server.