Add logo to login and password pages #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
steve-237
reviewed
Jul 26, 2022
Comment on lines
+2
to
+10
| <div class="logos"> | ||
| <img class="didentity_login" src="../../assets/images/DIdentity.png" alt="DIdentity" /> | ||
|
|
||
| <img | ||
| class="adorsys_login" | ||
| src="../../assets/images/adorsys.png" | ||
| alt="adorsys" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
I think it would be better to separate the logo from the cards for the login and the change password
There was a problem hiding this comment.
The problem is that then there would be a white box around each of the logos which looks quite awful. I tried it but it looks better inside the cards.
There was a problem hiding this comment.
OK I understand. But would if we place a separator between the logo and the title of the card it would be a little better?
There was a problem hiding this comment.
I do not think so
|
|
Signed-off-by: Valentin Bräutigam <valentin.braeutigam@gmail.com>
steve-237
approved these changes
Jul 26, 2022
Comment on lines
+2
to
+10
| <div class="logos"> | ||
| <img class="didentity_login" src="../../assets/images/DIdentity.png" alt="DIdentity" /> | ||
|
|
||
| <img | ||
| class="adorsys_login" | ||
| src="../../assets/images/adorsys.png" | ||
| alt="adorsys" | ||
| /> | ||
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the didentity and adorsys logo to the login page and the change password page