New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use 'cli export:playlist' after last update #3778
Comments
Look like you don't have enough right to |
cb7aa3e removed the
|
temporary fix, add in the public function get_m3u_string(): string {
return $this->create_m3u();
} EDIT : not a good fix, it print the M3U in the stdout instead of creating M3U files. Need more time, don't have right now :) |
does the job but may have unexpected problem: diff --git a/src/Module/Playback/Stream_Playlist.php b/src/Module/Playback/Stream_Playlist.php
index 1869914c4..dc5838e1f 100644
--- a/src/Module/Playback/Stream_Playlist.php
+++ b/src/Module/Playback/Stream_Playlist.php
@@ -536,11 +536,15 @@ class Stream_Playlist
}
}
+ public function get_m3u_string() {
+ return $this->create_m3u();
+ }
+
/**
* creates an m3u file, this includes the EXTINFO and as such can be
* large with very long playlists
*/
- public function create_m3u(): void
+ public function create_m3u()
{
$ret = "#EXTM3U\n";
@@ -549,7 +553,7 @@ class Stream_Playlist
$ret .= $url->url . "\n";
}
- echo $ret;
+ return $ret;
}
for compatibility: diff --git a/src/Module/Api/Subsonic_Api.php b/src/Module/Api/Subsonic_Api.php
index fdfffef4d..98ecdc58a 100644
--- a/src/Module/Api/Subsonic_Api.php
+++ b/src/Module/Api/Subsonic_Api.php
@@ -1550,7 +1550,7 @@ class Subsonic_Api
// vlc won't work if we use application/vnd.apple.mpegurl, but works fine with this. this is
// also an allowed header by the standard
header('Content-Type: audio/mpegurl;');
- $stream->create_m3u();
+ echo $stream->create_m3u();
}
|
Sorry for the noob question but is there an easy way to apply a patch via git or should I wait for this to be committed? |
Ran into several DB errors when updating via the GUI:
logs:
|
Not related to this issue, this is an upgrade issue (which can be expected on develop branch). This could go on a dedicated issue :) Commit related : 01868ad |
* Split the Update.php class into small migration classes (#3767) * Correct some type issues (#3770) * subsonic: do not send a different cover id for each song of the same album (#3768) * Use "Status" string rather than "State" which can be confused by Country (#3769) * Add opml import for podcasts #3737 (#3772) * Correct/Update some type hints related to recent stan errors (#3773) * Remove some unused code (#3774) * Fix #3778 (#3780) * Remove Flattr support (#3782) * Correct song metadata creation (#3777) * XBMC localplay improvements (#3783) * Correct doubled array index (#3784) * Solve an annoying api related type issue (#3785) * Remove unused imports (#3786) * Remove MetadataFieldRepository::findAll (#3787) * Correct some type issues due to the recent phpstan update (#3788) * Remove usages of Podcast::update() (#3789) * Try to bring back the scrutinizer code coverage (#3790) * Set scrutinizer memory-limit to indefinite (#3791) * Localplay and jukebox mode improvements ( Vlc and Xbmc ) (#3794) * Extract playlist import from Catalog_local (#3795) * Re-arrange the tag-count retrieval query (#3797) * Add ShareRepository and begin migrating some static methods (#3796) * Move podcast episode download limit retrieval into PodcastSyncer (#3799) * Perform some changes related to qa (#3798) * Remove php cs-sniffer from scrutinizer, too (#3800) * Vlc localplay improvements (#3802) * Rework the LicenseRepository (#3801) * Dont try to search for recommendations for invalid artists (#3805) * Update rector to 0.19 (#3803) * Replace License loading by repo-method (#3806) * Allow the user api method to return the current user info (#3807) * Replace the metadata-repositories (#3804) * Split up podcast-related repositories (#3808) * Replace all remaining usages of Core::verify_form by RequestParser (#3810) * Start reworking the PrivateMessageRepository (#3811) * Refactor Wanted- and LiveStreamRepository (#3809) * scrub_in all the search inputs (#3825) * Upgrade rector to its first major version (#3818) * Cleanup/Optimize some qa-related settings (#3821) * Correct a bunch of type issues (#3822) * Start replacing podcast-episode properties with getters (#3823) * Define defaults for democratic playlist properties (#3826) * Start the implementation of a BaseRepository and a generic ModelInterface (#3819) * Add tests for BookmarkRepository (#3820) * Add ImageRepository (#3824) * Prepare the WantedRepository to extend BaseRepository (#3828) * Extract missing-artist retrieval from Wanted (#3829) * Align Catalog properties types to the database columns (#3832) * dono't query an empty query (#3835) * Extract cleanup methods from Art-class (#3827) * Add tests for LabelRepository (#3831) * Really show default favicon by default (#3842) * Replace the f_file and f_full_title properties by a method (#3836) * Extract more wanted-logic into separate classes (#3837) * Move database-related methods from Share into ShareRepo (#3838) * Extract the creation of new share-items (#3840) * Move some more methods from Artist/Album into their repos (#3843) * Remove stray span and use valid lang value on installer pages (#3849) * Fix the publication date of RSS feeds. (#3861) * Remove genre and stream from useractivity deletion (#3866) --------- Co-authored-by: Daniel Jakob <github@usox.org> Co-authored-by: cquike <17937361+cquike@users.noreply.github.com> Co-authored-by: fufroma <fufroma@users.noreply.github.com> Co-authored-by: Carlo Sardi <lusum@users.noreply.github.com> Co-authored-by: Mitch Ray <5735900+mitchray@users.noreply.github.com> Co-authored-by: François Charlier <fcharlier@users.noreply.github.com>
Description
Describe the bug
Upgraded to latest development branch and ran composer install. Things seem to be working except on the cli interface:
Expected behavior
This used to work in a cron:
Environment
Client type
cli
Settings
Logs
No logs generated even when running the cli as root:
The text was updated successfully, but these errors were encountered: