Correct song metadata creation #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation of new metadata entries broke with 22edc6a. This fixes the creation and adds the replacemant repositories for the existing Metadata(Field)Repositories.
|
Code Climate has analyzed commit e487144 and detected 18 issues on this pull request. Here's the issue category breakdown:
Note: there are 6 critical issues. View more on Code Climate. |
|
that's a great step, those classes were weird and scary in their current state |
|
Yeah, I'll remove them completly after migrating the logic. We surely don't need three different approaches of how we manage the database access... |
lachlan-00
added a commit
that referenced
this pull request
Mar 13, 2024
* Split the Update.php class into small migration classes (#3767) * Correct some type issues (#3770) * subsonic: do not send a different cover id for each song of the same album (#3768) * Use "Status" string rather than "State" which can be confused by Country (#3769) * Add opml import for podcasts #3737 (#3772) * Correct/Update some type hints related to recent stan errors (#3773) * Remove some unused code (#3774) * Fix #3778 (#3780) * Remove Flattr support (#3782) * Correct song metadata creation (#3777) * XBMC localplay improvements (#3783) * Correct doubled array index (#3784) * Solve an annoying api related type issue (#3785) * Remove unused imports (#3786) * Remove MetadataFieldRepository::findAll (#3787) * Correct some type issues due to the recent phpstan update (#3788) * Remove usages of Podcast::update() (#3789) * Try to bring back the scrutinizer code coverage (#3790) * Set scrutinizer memory-limit to indefinite (#3791) * Localplay and jukebox mode improvements ( Vlc and Xbmc ) (#3794) * Extract playlist import from Catalog_local (#3795) * Re-arrange the tag-count retrieval query (#3797) * Add ShareRepository and begin migrating some static methods (#3796) * Move podcast episode download limit retrieval into PodcastSyncer (#3799) * Perform some changes related to qa (#3798) * Remove php cs-sniffer from scrutinizer, too (#3800) * Vlc localplay improvements (#3802) * Rework the LicenseRepository (#3801) * Dont try to search for recommendations for invalid artists (#3805) * Update rector to 0.19 (#3803) * Replace License loading by repo-method (#3806) * Allow the user api method to return the current user info (#3807) * Replace the metadata-repositories (#3804) * Split up podcast-related repositories (#3808) * Replace all remaining usages of Core::verify_form by RequestParser (#3810) * Start reworking the PrivateMessageRepository (#3811) * Refactor Wanted- and LiveStreamRepository (#3809) * scrub_in all the search inputs (#3825) * Upgrade rector to its first major version (#3818) * Cleanup/Optimize some qa-related settings (#3821) * Correct a bunch of type issues (#3822) * Start replacing podcast-episode properties with getters (#3823) * Define defaults for democratic playlist properties (#3826) * Start the implementation of a BaseRepository and a generic ModelInterface (#3819) * Add tests for BookmarkRepository (#3820) * Add ImageRepository (#3824) * Prepare the WantedRepository to extend BaseRepository (#3828) * Extract missing-artist retrieval from Wanted (#3829) * Align Catalog properties types to the database columns (#3832) * dono't query an empty query (#3835) * Extract cleanup methods from Art-class (#3827) * Add tests for LabelRepository (#3831) * Really show default favicon by default (#3842) * Replace the f_file and f_full_title properties by a method (#3836) * Extract more wanted-logic into separate classes (#3837) * Move database-related methods from Share into ShareRepo (#3838) * Extract the creation of new share-items (#3840) * Move some more methods from Artist/Album into their repos (#3843) * Remove stray span and use valid lang value on installer pages (#3849) * Fix the publication date of RSS feeds. (#3861) * Remove genre and stream from useractivity deletion (#3866) --------- Co-authored-by: Daniel Jakob <github@usox.org> Co-authored-by: cquike <17937361+cquike@users.noreply.github.com> Co-authored-by: fufroma <fufroma@users.noreply.github.com> Co-authored-by: Carlo Sardi <lusum@users.noreply.github.com> Co-authored-by: Mitch Ray <5735900+mitchray@users.noreply.github.com> Co-authored-by: François Charlier <fcharlier@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of new metadata entries broke with 22edc6a. This fixes the creation and adds the replacemant repositories for the existing Metadata(Field)Repositories.