Include :jar-exclusions in fingerprints #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonvin
force-pushed
the
jar-exclusions-fingerprint
branch
from
e6e74b2
to
1ba1afe
Compare
DCardenasAmp
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Nice, I didn't realize adding a new fingerprint would be that simple!
Pulled this locally and tested this against the example projects, and confirmed that
- Setting
:jar-exclusionson an individual project will update its fingerprint - Setting
:jar-exclusionsas an inherited property in the metaproject file will update the fingerprint of any projects that inherit it
greglook
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:jar-exclusionscan alter the contents of a project's JAR file, so when it's changed the project should be considered stale.