Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dates_times.am_pm.lowercase_periods is triggered when using uppercase letters #777

Closed
NateEag opened this issue Feb 8, 2018 · 2 comments · Fixed by #620
Closed

dates_times.am_pm.lowercase_periods is triggered when using uppercase letters #777

NateEag opened this issue Feb 8, 2018 · 2 comments · Fixed by #620
Labels
bug: fixed Bugs that have been fixed. cat: false-positive Issues and PRs related to false positives in proselint rules. priority: low Issues and PRs that should be resolved, but can be postponed. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.

Comments

@NateEag
Copy link

NateEag commented Feb 8, 2018

Witness the following bash session:

$  proselint <(echo 'It is 6:00 PM, you know.')
/dev/fd/63:1:9: dates_times.am_pm.lowercase_periods With lowercase letters, the periods are standard.
$ proselint --version
0.8.0

Since the check is explicitly for lowercase letters, it should not be triggered when writing with uppercase letters.

I tried locally hacking this call to existence_check to include an ignore_case=False keyword arg, but it does not seem to have changed the behavior.

@NateEag NateEag changed the title dates_times.am_pm.lowercase_periods is triggered when using uppercase letter dates_times.am_pm.lowercase_periods is triggered when using uppercase letters Feb 8, 2018
@KVGarg
Copy link

KVGarg commented Oct 18, 2018

Hi @NateEag , when you passed ignore_case=False as an argument, you might not have changed the text due to which you got the same error again. This happened because the decorator @memoize memorize's the input text in cache due to which you get the same error again on passing same input text to the check. Try with different text by passing ignore_case=False as argument to existence_check.

I have opened a PR with the correction in code.

KVGarg added a commit to KVGarg/proselint that referenced this issue Oct 18, 2018
@Nytelife26 Nytelife26 added the status: awaiting-triage Issues and PRs awaiting investigation and relabelling. label May 29, 2021
@Nytelife26 Nytelife26 added bug: fixed-in-next Bugs present in the current release but fixed on the main branch. cat: false-positive Issues and PRs related to false positives in proselint rules. priority: high Issues and PRs that should be resolved as soon as possible. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release. and removed status: awaiting-triage Issues and PRs awaiting investigation and relabelling. labels Jul 11, 2021
@Nytelife26 Nytelife26 linked a pull request Jul 11, 2021 that will close this issue
@Nytelife26 Nytelife26 added priority: low Issues and PRs that should be resolved, but can be postponed. and removed priority: high Issues and PRs that should be resolved as soon as possible. labels Jul 11, 2021
@Nytelife26
Copy link
Member

This will be fixed by the next release.

@Nytelife26 Nytelife26 added bug: fixed Bugs that have been fixed. and removed bug: fixed-in-next Bugs present in the current release but fixed on the main branch. labels Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: fixed Bugs that have been fixed. cat: false-positive Issues and PRs related to false positives in proselint rules. priority: low Issues and PRs that should be resolved, but can be postponed. type: fix Issues and PRs related to bugs. version: patch Issues and PRs with bug fixes belonging to the next patch release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants