fix(checks): make am_pm check case sensitive #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the close/reopen; I momentarily wanted nothing to do with this project after getting shit on in one of the issue threads. |
Nytelife26
added
the
status: awaiting-triage
Nytelife26
added
bug: confirmed
Closed
Nytelife26
force-pushed
the
actually-lower-case
branch
from
1e67e30
to
e6b23cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 82 82
Lines 1131 1131
=======================================
Hits 1067 1067
Misses 64 64
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nytelife26
force-pushed
the
actually-lower-case
branch
from
e6b23cd
to
6502c97
Compare
Nytelife26
changed the title
Nytelife26
force-pushed
the
actually-lower-case
branch
from
6502c97
to
b2d1d26
Compare
Nytelife26
approved these changes
Jul 11, 2021
|
Good fix, thanks for the PR - and I'm sorry for whatever happened in that issue all that time ago. |
Nytelife26
changed the title
Nytelife26
added
bug: fixed-in-next
Nytelife26
removed
the
status: wip
Nytelife26
added
bug: fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon using proselint on an email, I immediately noticed that "lowercase am/pm" was not checking that am/pm was actually lower case.
I attempted to fix that here (and throw in some tests). But, I'm not a python hacker, and I have no idea what the usual workflows are for python projects. I did run
nosetestswithin the tests directory, but my new test still fails. Is there some build step I'm missing? Or is my test broken?P.S. It would be great if you could throw a few words into the contributing guide about how to approach the project as an absolute Python beginner. E.g. is
pip install --user --upgrade .the right way to install a modified version? Or, how do I run it without even installing it locally? :)