Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid promise resolution for cached failures #26

Closed
kelunik opened this issue Feb 23, 2016 · 0 comments
Closed

Invalid promise resolution for cached failures #26

kelunik opened this issue Feb 23, 2016 · 0 comments
Assignees
@bwoebi
Labels
bug

Comments

@kelunik
Copy link
Member

kelunik commented Feb 23, 2016

We currently cache in case of no results for a maximum of 5 minutes. The first invocation results in a ResolutionException (should actually be NoRecordException, see #25). All later invocations result in an successfully resolved promise yielding an empty array. Instead there should be the same outcome as for non-cached DNS requests (the same exception).
@kelunik kelunik added the bug label Feb 23, 2016
bwoebi added a commit that referenced this issue Mar 14, 2016
@bwoebi
Fix issues #25 and #26
daf859e
@bwoebi bwoebi closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwoebi bwoebi

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelunik @bwoebi