Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#18 auth banner support #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#18 auth banner support #19

wants to merge 1 commit into from

Conversation

Ekstazi
Copy link
Contributor

@Ekstazi Ekstazi commented Jun 18, 2019

No description provided.

joelwurtz
joelwurtz requested changes Jun 19, 2019
View reviewed changes
Copy link
Collaborator

@joelwurtz joelwurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what i understand, we correctly go the auth banner when connecting, however there is no API to retrieve it / read it from an user point of view. I think it miss this to be a fully functional PR.

src/Authentication/PublicKey.php
@@ -87,6 +92,10 @@ private function rsa(BinaryPacketHandler $handler, $key, array $privateKeyInfo,
yield $handler->write($request);
$package = yield $handler->read();

if($package instanceof UserAuthBanner) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss space after if

src/Authentication/PublicKey.php
@@ -112,6 +121,10 @@ private function rsa(BinaryPacketHandler $handler, $key, array $privateKeyInfo,
yield $handler->write($signatureRequest);
$packet = yield $handler->read();

if($packet instanceof UserAuthBanner) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss space after if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelwurtz joelwurtz joelwurtz requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ekstazi @joelwurtz