Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18 auth banner support #19

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@Ekstazi
Copy link
Collaborator

commented Jun 18, 2019

No description provided.

@joelwurtz
Copy link
Collaborator

left a comment

From what i understand, we correctly go the auth banner when connecting, however there is no API to retrieve it / read it from an user point of view. I think it miss this to be a fully functional PR.

@@ -87,6 +92,10 @@ private function rsa(BinaryPacketHandler $handler, $key, array $privateKeyInfo,
yield $handler->write($request);
$package = yield $handler->read();
if($package instanceof UserAuthBanner) {

This comment has been minimized.

Copy link
@joelwurtz

joelwurtz Jun 19, 2019

Collaborator

miss space after if

@@ -112,6 +121,10 @@ private function rsa(BinaryPacketHandler $handler, $key, array $privateKeyInfo,
yield $handler->write($signatureRequest);
$packet = yield $handler->read();
if($packet instanceof UserAuthBanner) {

This comment has been minimized.

Copy link
@joelwurtz

joelwurtz Jun 19, 2019

Collaborator

miss space after if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.